fix: react native demo app nits#387
Conversation
EXPLO_PUBLIC_APP_ID → EXPO_PUBLIC_APP_ID The correct variable name is used everywhere else in the codebase including providers.tsx and .env.example.
… code The Configuration section showed debug as a property inside the main config object, but providers.tsx correctly uses a separate debugConfig object passed as its own prop to PhantomProvider. Updated the snippet to match so developers following the README don't hit type errors.
Replace real UUID fallback (57b8172b-...) with "your-app-id" to match the README convention and make it clear developers need to supply their own value from the Phantom developer portal.
📝 WalkthroughWalkthroughConfiguration updates to the React Native SDK demo app including a corrected environment variable name, explicit type annotations for SDK config, introduction of a new debug configuration object passed to the provider, and a default app ID placeholder update. Changes
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
examples/react-native-sdk-demo-app/README.md (1)
119-135:⚠️ Potential issue | 🟠 MajorKeep this snippet in sync with
app/providers.tsx.This block is not copy/pasteable as written. The actual example includes a required
providers: ["google", "apple"]field that the README omits. Additionally, the real code usesisEmbeddedWalletType()type guards to validate the wallet type, but the README replaces this with(process.env.EXPO_PUBLIC_EMBEDDED_WALLET_TYPE || "user-wallet") as const—a different code path that does not match the source. Finally, the snippet referencesEXPO_PUBLIC_APP_IDon line 122, but this environment variable is not documented in the "Environment Variables" section above. Mirror the actual example here instead of maintaining a hand-edited variant.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@examples/react-native-sdk-demo-app/README.md` around lines 119 - 135, Update the README code snippet to exactly mirror app/providers.tsx: include the required providers: ["google", "apple"] field in the config, replace the ad-hoc cast for embeddedWalletType with the same runtime/type guard flow using isEmbeddedWalletType(...) and the same default logic used in app/providers.tsx, ensure PhantomProvider usage matches (PhantomProvider and config symbols), and add EXPO_PUBLIC_APP_ID to the "Environment Variables" section so the env var referenced in the snippet is documented.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@examples/react-native-sdk-demo-app/README.md`:
- Around line 119-135: Update the README code snippet to exactly mirror
app/providers.tsx: include the required providers: ["google", "apple"] field in
the config, replace the ad-hoc cast for embeddedWalletType with the same
runtime/type guard flow using isEmbeddedWalletType(...) and the same default
logic used in app/providers.tsx, ensure PhantomProvider usage matches
(PhantomProvider and config symbols), and add EXPO_PUBLIC_APP_ID to the
"Environment Variables" section so the env var referenced in the snippet is
documented.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 796082f6-1b6b-40ef-bf73-705f3c1f9db2
📒 Files selected for processing (2)
examples/react-native-sdk-demo-app/README.mdexamples/react-native-sdk-demo-app/app/providers.tsx
Summary & Motivation
This PR makes three small fixes to the
react-native-sdk-demo-appexample:EXPLO->EXPO5cc110e"your-app-id"305e4bdHow I Tested These Changes
These changes are documentation/string replacements in example code - no functional changes. I checked against the conventions used in other source files
Did you add a changeset?
I did not add a changeset as the changes I made are isolated to
examples/and the package code is not modified.Did you update the README files?
Yes - the primary change I am making here includes some updates to the README
Summary by CodeRabbit
Documentation
Chores