Skip to content

fix: react native demo app nits#387

Open
pete-watters wants to merge 4 commits intophantom:mainfrom
pete-watters:fix/react-native-demo-app-nits
Open

fix: react native demo app nits#387
pete-watters wants to merge 4 commits intophantom:mainfrom
pete-watters:fix/react-native-demo-app-nits

Conversation

@pete-watters
Copy link
Copy Markdown

@pete-watters pete-watters commented Mar 9, 2026

Summary & Motivation

This PR makes three small fixes to the react-native-sdk-demo-app example:

  • typo in the README - EXPLO -> EXPO 5cc110e
  • updating a config snippet to match actual code more closely ad86403
  • replace a hardcoded UUID with the "your-app-id" 305e4bd

How I Tested These Changes

These changes are documentation/string replacements in example code - no functional changes. I checked against the conventions used in other source files

Did you add a changeset?

I did not add a changeset as the changes I made are isolated to examples/ and the package code is not modified.

Did you update the README files?

Yes - the primary change I am making here includes some updates to the README

Summary by CodeRabbit

  • Documentation

    • Updated demo app configuration documentation with corrected environment variable naming and added debug configuration examples.
  • Chores

    • Updated demo app configuration to support debug mode via environment variable and corrected placeholder values.

EXPLO_PUBLIC_APP_ID → EXPO_PUBLIC_APP_ID

The correct variable name is used everywhere else in the codebase
including providers.tsx and .env.example.
… code

The Configuration section showed debug as a property inside the main
config object, but providers.tsx correctly uses a separate debugConfig
object passed as its own prop to PhantomProvider. Updated the snippet
to match so developers following the README don't hit type errors.
Replace real UUID fallback (57b8172b-...) with "your-app-id" to match
the README convention and make it clear developers need to supply their
own value from the Phantom developer portal.
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 9, 2026

📝 Walkthrough

Walkthrough

Configuration updates to the React Native SDK demo app including a corrected environment variable name, explicit type annotations for SDK config, introduction of a new debug configuration object passed to the provider, and a default app ID placeholder update.

Changes

Cohort / File(s) Summary
Configuration Updates
examples/react-native-sdk-demo-app/README.md, examples/react-native-sdk-demo-app/app/providers.tsx
Environment variable corrected from EXPLO_PUBLIC_APP_ID to EXPO_PUBLIC_APP_ID, explicit PhantomSDKConfig type annotation added, new debugConfig object of type PhantomDebugConfig introduced with enabled derived from EXPO_PUBLIC_DEBUG environment variable, debugConfig prop added to PhantomProvider, and default app ID placeholder changed to "your-app-id".
🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'fix: react native demo app nits' is vague and uses the non-descriptive term 'nits' without clearly conveying the specific nature of the changes being made. Consider using a more specific title that describes the actual fixes, such as 'fix: correct React Native demo app configuration and environment variables' or similar.
✅ Passed checks (2 passed)
Check name Status Explanation
Description check ✅ Passed The description comprehensively covers all required sections with clear explanations of the three fixes, testing approach, and changeset justification.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pete-watters pete-watters changed the title Fix/react native demo app nits fix: react native demo app nits Mar 9, 2026
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
examples/react-native-sdk-demo-app/README.md (1)

119-135: ⚠️ Potential issue | 🟠 Major

Keep this snippet in sync with app/providers.tsx.

This block is not copy/pasteable as written. The actual example includes a required providers: ["google", "apple"] field that the README omits. Additionally, the real code uses isEmbeddedWalletType() type guards to validate the wallet type, but the README replaces this with (process.env.EXPO_PUBLIC_EMBEDDED_WALLET_TYPE || "user-wallet") as const—a different code path that does not match the source. Finally, the snippet references EXPO_PUBLIC_APP_ID on line 122, but this environment variable is not documented in the "Environment Variables" section above. Mirror the actual example here instead of maintaining a hand-edited variant.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@examples/react-native-sdk-demo-app/README.md` around lines 119 - 135, Update
the README code snippet to exactly mirror app/providers.tsx: include the
required providers: ["google", "apple"] field in the config, replace the ad-hoc
cast for embeddedWalletType with the same runtime/type guard flow using
isEmbeddedWalletType(...) and the same default logic used in app/providers.tsx,
ensure PhantomProvider usage matches (PhantomProvider and config symbols), and
add EXPO_PUBLIC_APP_ID to the "Environment Variables" section so the env var
referenced in the snippet is documented.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Outside diff comments:
In `@examples/react-native-sdk-demo-app/README.md`:
- Around line 119-135: Update the README code snippet to exactly mirror
app/providers.tsx: include the required providers: ["google", "apple"] field in
the config, replace the ad-hoc cast for embeddedWalletType with the same
runtime/type guard flow using isEmbeddedWalletType(...) and the same default
logic used in app/providers.tsx, ensure PhantomProvider usage matches
(PhantomProvider and config symbols), and add EXPO_PUBLIC_APP_ID to the
"Environment Variables" section so the env var referenced in the snippet is
documented.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 796082f6-1b6b-40ef-bf73-705f3c1f9db2

📥 Commits

Reviewing files that changed from the base of the PR and between facd553 and 305e4bd.

📒 Files selected for processing (2)
  • examples/react-native-sdk-demo-app/README.md
  • examples/react-native-sdk-demo-app/app/providers.tsx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant