Whitelist soulterminal.ai (false positive) - #1840
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
Included review availability: 4 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour. 📝 WalkthroughWalkthroughThe whitelist now includes ChangesWhitelist domain update
Merge Risk: 🔵 Low · up to This change adds soulterminal.ai and a wildcard entry covering its subdomains to the allowlist. If enforced downstream, that could extend trusted scope to any matching subdomain, while the repository does not define the matching boundary or establish control of the full namespace. The PR is mergeable with explicit owner awareness or follow-up to confirm those controls or limit the entries to verified hosts. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@MarbleGarden Could you please help review this false positive, similar to your investigation in #1797?
Because the repository notes that |
Summary
Adds
soulterminal.aiand its controlled subdomains towhitelist.yamlfollowing a Phantom-specific false-positive warning.Why this is a false positive
Phantom currently redirects visits to
soulterminal.aito its malicious-site warning. The domain is not present in the repository's currentblocklist.yaml, and the warning has not been reproduced in the other browsers and crypto wallet applications tested.Soul Terminal is a public Solana token-discovery and market-information interface. Its current public login surface does not offer wallet connections or wallet-based authentication; authentication is handled through Telegram.
Public verification resources:
The homepage intentionally uses a Cloudflare Managed Challenge. The
/trustand/.well-known/security.txtresources are public and return HTTP 200 without requiring authentication or a wallet connection.I understand the repository README says
whitelist.yamlis not currently consumed by the production extension. In addition to the allowlist entry, please treat this PR as a request to review and remove the heuristic or internal reputation flag causing Phantom's warning.Validation
node ./ci.jsyarn buildwhitelist.yamland verified both new entries are presentSummary by CodeRabbit
soulterminal.aiand its subdomains.nftplus.io.