Fix build against PostgreSQL 19 - #383
Merged
Merged
Conversation
1. pc_access.c
PG19 removed the `bits8` typedef (utils/array.h now uses `uint8`
directly, e.g. ARR_NULLBITMAP() returns uint8*). Replace all uses
of `bits8` with `uint8` (array_get_isnull(), pcpatch_from_point_array(),
pcpatch_from_patch_array(), array_to_cstring_array()).
2. pc_pgsql.c
PG19 added an `int *fgc_flags` output parameter to
FuncnameGetCandidates() (8 args instead of 7), used to report why a
lookup failed. Add a new `#elif PGSQL_VERSION < 190` branch that
keeps the existing PG14-PG18 (7-arg) call, and a PG19+ branch that
passes a local `int fgc_flags` to satisfy the new signature. The
flags aren't otherwise consumed since this call only wants the OID
of a uniquely-named function.
lbartoletti
approved these changes
Jul 30, 2026
lbartoletti
left a comment
lbartoletti
left a comment
Contributor
There was a problem hiding this comment.
LGTM, is it ok for you @pblottiere ?
Member
|
Thanks a lot for the MR @devrimgunduz 🙏. I'm going to merge it as is, and I will add CI tests against PG 19 (and PG 18) during the week. Once everything is green, I will make a new release including these changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pc_access.c PG19 removed the
bits8typedef (utils/array.h now usesuint8directly, e.g. ARR_NULLBITMAP() returns uint8*). Replace all uses ofbits8withuint8(array_get_isnull(), pcpatch_from_point_array(), pcpatch_from_patch_array(), array_to_cstring_array()).pc_pgsql.c PG19 added an
int *fgc_flagsoutput parameter to FuncnameGetCandidates() (8 args instead of 7), used to report why a lookup failed. Add a new#elif PGSQL_VERSION < 190branch that keeps the existing PG14-PG18 (7-arg) call, and a PG19+ branch that passes a localint fgc_flagsto satisfy the new signature. The flags aren't otherwise consumed since this call only wants the OID of a uniquely-named function.Per pgdg-packaging/pgdg-rpms#213