Skip to content

fix: deadlock in multi-shard SELECT queries#864

Merged
levkk merged 1 commit intomainfrom
levkk-fix-multi
Apr 2, 2026
Merged

fix: deadlock in multi-shard SELECT queries#864
levkk merged 1 commit intomainfrom
levkk-fix-multi

Conversation

@levkk
Copy link
Copy Markdown
Collaborator

@levkk levkk commented Apr 2, 2026

SELECT queries that read data from less than the total number of shards (multi-shard connection binding) would deadlock because we were incorrectly sending the query to less than the total number of shards.

This didn't affect cross-shard (all-shard) queries or direct to shard queries.

@levkk levkk changed the title fix: deadlock in multi-shard queries fix: deadlock in multi-shard SELECT queries Apr 2, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 2, 2026

Codecov Report

❌ Patch coverage is 97.47899% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pgdog/src/backend/pool/connection/binding.rs 40.00% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

@levkk levkk merged commit c5188ce into main Apr 2, 2026
7 of 8 checks passed
@levkk levkk deleted the levkk-fix-multi branch April 2, 2026 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant