Skip to content

clang-tidy: fix warnings of cppcoreguidelines-init-variables #3083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ayushjariyal wants to merge 7 commits into
base: develop
Choose a base branch
from
+599 −667
Open

clang-tidy: fix warnings of cppcoreguidelines-init-variables #3083

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a766967
fix warnings of cppcoreguidelines-init-variables
ayushjariyal Feb 28, 2026
d488766
enabling workflow
ayushjariyal Mar 2, 2026
f584725
remove extra space
ayushjariyal Mar 2, 2026
bd52055
Merge branch 'develop' into fix-clag-tidy-for-init-variables
ayushjariyal Mar 3, 2026
ff97ab8
remove duplicate line
ayushjariyal Mar 4, 2026
d2329ff
Update src/max_flow/max_flow.c
ayushjariyal Mar 4, 2026
41b6fd9
Remove unnecessary initialization by declaring variable inside for loop
ayushjariyal Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/allpairs/floydWarshall.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,14 +37,14 @@ PG_FUNCTION_INFO_V1(_pgr_floydwarshall);

PGDLLEXPORT Datum
_pgr_floydwarshall(PG_FUNCTION_ARGS) {
FuncCallContext *funcctx;
TupleDesc tuple_desc;
FuncCallContext *funcctx = NULL;
TupleDesc tuple_desc = NULL;

IID_t_rt *result_tuples = NULL;
size_t result_count = 0;

if (SRF_IS_FIRSTCALL()) {
MemoryContext oldcontext;
MemoryContext oldcontext = NULL;
funcctx = SRF_FIRSTCALL_INIT();
oldcontext = MemoryContextSwitchTo(funcctx->multi_call_memory_ctx);

Expand Down Expand Up @@ -74,10 +74,10 @@ _pgr_floydwarshall(PG_FUNCTION_ARGS) {
result_tuples = (IID_t_rt*) funcctx->user_fctx;

if (funcctx->call_cntr < funcctx->max_calls) {
HeapTuple tuple;
Datum result;
Datum *values;
bool* nulls;
HeapTuple tuple = NULL;
Datum result = 0;
Datum *values = NULL;
bool* nulls = NULL;

values = palloc(3 * sizeof(Datum));
nulls = palloc(3 * sizeof(bool));
Expand Down
14 changes: 7 additions & 7 deletions src/allpairs/johnson.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,14 +38,14 @@ PG_FUNCTION_INFO_V1(_pgr_johnson);

PGDLLEXPORT Datum
_pgr_johnson(PG_FUNCTION_ARGS) {
FuncCallContext *funcctx;
TupleDesc tuple_desc;
FuncCallContext *funcctx = NULL;
TupleDesc tuple_desc = NULL;

IID_t_rt *result_tuples = NULL;
size_t result_count = 0;

if (SRF_IS_FIRSTCALL()) {
MemoryContext oldcontext;
MemoryContext oldcontext = NULL;
funcctx = SRF_FIRSTCALL_INIT();
oldcontext = MemoryContextSwitchTo(funcctx->multi_call_memory_ctx);

Expand Down Expand Up @@ -75,10 +75,10 @@ _pgr_johnson(PG_FUNCTION_ARGS) {
result_tuples = (IID_t_rt*) funcctx->user_fctx;

if (funcctx->call_cntr < funcctx->max_calls) {
HeapTuple tuple;
Datum result;
Datum *values;
bool *nulls;
HeapTuple tuple = NULL;
Datum result = 0;
Datum *values = NULL;
bool *nulls = NULL;

values = palloc(3 * sizeof(Datum));
nulls = palloc(3 * sizeof(bool));
Expand Down
17 changes: 8 additions & 9 deletions src/astar/astar.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,14 +38,14 @@ PG_FUNCTION_INFO_V1(_pgr_astar);


PGDLLEXPORT Datum _pgr_astar(PG_FUNCTION_ARGS) {
FuncCallContext *funcctx;
TupleDesc tuple_desc;
FuncCallContext *funcctx = NULL;
TupleDesc tuple_desc = NULL;

Path_rt *result_tuples = NULL;
size_t result_count = 0;

if (SRF_IS_FIRSTCALL()) {
MemoryContext oldcontext;
MemoryContext oldcontext = NULL;
funcctx = SRF_FIRSTCALL_INIT();
oldcontext = MemoryContextSwitchTo(funcctx->multi_call_memory_ctx);

Expand Down Expand Up @@ -112,18 +112,17 @@ PGDLLEXPORT Datum _pgr_astar(PG_FUNCTION_ARGS) {
result_tuples = (Path_rt*) funcctx->user_fctx;

if (funcctx->call_cntr < funcctx->max_calls) {
HeapTuple tuple;
Datum result;
Datum *values;
bool* nulls;
HeapTuple tuple = NULL;
Datum result = 0;
Datum *values = NULL;
bool* nulls = NULL;
size_t call_cntr = funcctx->call_cntr;

size_t numb = 8;
values = palloc(numb * sizeof(Datum));
nulls = palloc(numb * sizeof(bool));

size_t i;
for (i = 0; i < numb; ++i) {
for (size_t i = 0; i < numb; ++i) {
nulls[i] = false;
}

Expand Down
17 changes: 8 additions & 9 deletions src/bdAstar/bdAstar.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,14 +39,14 @@ PG_FUNCTION_INFO_V1(_pgr_bdastar);

PGDLLEXPORT Datum
_pgr_bdastar(PG_FUNCTION_ARGS) {
FuncCallContext *funcctx;
TupleDesc tuple_desc;
FuncCallContext *funcctx = NULL;
TupleDesc tuple_desc = NULL;

Path_rt *result_tuples = NULL;
size_t result_count = 0;

if (SRF_IS_FIRSTCALL()) {
MemoryContext oldcontext;
MemoryContext oldcontext = NULL;
funcctx = SRF_FIRSTCALL_INIT();
oldcontext = MemoryContextSwitchTo(funcctx->multi_call_memory_ctx);

Expand Down Expand Up @@ -113,18 +113,17 @@ _pgr_bdastar(PG_FUNCTION_ARGS) {
result_tuples = (Path_rt*) funcctx->user_fctx;

if (funcctx->call_cntr < funcctx->max_calls) {
HeapTuple tuple;
Datum result;
Datum *values;
bool* nulls;
HeapTuple tuple = NULL;
Datum result = 0;
Datum *values = NULL;
bool* nulls = NULL;
size_t call_cntr = funcctx->call_cntr;

size_t numb = 8;
values = palloc(numb * sizeof(Datum));
nulls = palloc(numb * sizeof(bool));

size_t i;
for (i = 0; i < numb; ++i) {
for (size_t i = 0; i < numb; ++i) {
nulls[i] = false;
}

Expand Down
17 changes: 8 additions & 9 deletions src/bdDijkstra/bdDijkstra.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,14 +38,14 @@ PG_FUNCTION_INFO_V1(_pgr_bddijkstra);


PGDLLEXPORT Datum _pgr_bddijkstra(PG_FUNCTION_ARGS) {
FuncCallContext *funcctx;
TupleDesc tuple_desc;
FuncCallContext *funcctx = NULL;
TupleDesc tuple_desc = NULL;

Path_rt *result_tuples = NULL;
size_t result_count = 0;

if (SRF_IS_FIRSTCALL()) {
MemoryContext oldcontext;
MemoryContext oldcontext = NULL;
funcctx = SRF_FIRSTCALL_INIT();
oldcontext = MemoryContextSwitchTo(funcctx->multi_call_memory_ctx);
if (PG_NARGS() == 5) {
Expand Down Expand Up @@ -117,18 +117,17 @@ PGDLLEXPORT Datum _pgr_bddijkstra(PG_FUNCTION_ARGS) {
result_tuples = (Path_rt*) funcctx->user_fctx;

if (funcctx->call_cntr < funcctx->max_calls) {
HeapTuple tuple;
Datum result;
Datum *values;
bool* nulls;
HeapTuple tuple = NULL;
Datum result = 0;
Datum *values = NULL;
bool* nulls = NULL;
size_t call_cntr = funcctx->call_cntr;

size_t numb = 8;
values = palloc(numb * sizeof(Datum));
nulls = palloc(numb * sizeof(bool));

size_t i;
for (i = 0; i < numb; ++i) {
for (size_t i = 0; i < numb; ++i) {
nulls[i] = false;
}

Expand Down
17 changes: 8 additions & 9 deletions src/bellman_ford/bellman_ford.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,14 +90,14 @@ process(

PGDLLEXPORT Datum
_pgr_bellmanford(PG_FUNCTION_ARGS) {
FuncCallContext *funcctx;
TupleDesc tuple_desc;
FuncCallContext *funcctx = NULL;
TupleDesc tuple_desc = NULL;

Path_rt *result_tuples = NULL;
size_t result_count = 0;

if (SRF_IS_FIRSTCALL()) {
MemoryContext oldcontext;
MemoryContext oldcontext = NULL;
funcctx = SRF_FIRSTCALL_INIT();
oldcontext = MemoryContextSwitchTo(funcctx->multi_call_memory_ctx);

Expand Down Expand Up @@ -149,17 +149,16 @@ _pgr_bellmanford(PG_FUNCTION_ARGS) {
result_tuples = (Path_rt*) funcctx->user_fctx;

if (funcctx->call_cntr < funcctx->max_calls) {
HeapTuple tuple;
Datum result;
Datum *values;
bool* nulls;
HeapTuple tuple = NULL;
Datum result = 0;
Datum *values = NULL;
bool* nulls = NULL;

size_t numb = 8;
values = palloc(numb * sizeof(Datum));
nulls = palloc(numb * sizeof(bool));

size_t i;
for (i = 0; i < numb; ++i) {
for (size_t i = 0; i < numb; ++i) {
nulls[i] = false;
}

Expand Down
17 changes: 8 additions & 9 deletions src/bellman_ford/bellman_ford_neg.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,14 +92,14 @@ process(

PGDLLEXPORT Datum
_pgr_bellmanfordneg(PG_FUNCTION_ARGS) {
FuncCallContext *funcctx;
TupleDesc tuple_desc;
FuncCallContext *funcctx = NULL;
TupleDesc tuple_desc = NULL;

Path_rt *result_tuples = NULL;
size_t result_count = 0;

if (SRF_IS_FIRSTCALL()) {
MemoryContext oldcontext;
MemoryContext oldcontext = NULL;
funcctx = SRF_FIRSTCALL_INIT();
oldcontext = MemoryContextSwitchTo(funcctx->multi_call_memory_ctx);

Expand Down Expand Up @@ -152,17 +152,16 @@ _pgr_bellmanfordneg(PG_FUNCTION_ARGS) {
result_tuples = (Path_rt*) funcctx->user_fctx;

if (funcctx->call_cntr < funcctx->max_calls) {
HeapTuple tuple;
Datum result;
Datum *values;
bool* nulls;
HeapTuple tuple = NULL;
Datum result = 0;
Datum *values = NULL;
bool* nulls = NULL;

size_t numb = 8;
values = palloc(numb * sizeof(Datum));
nulls = palloc(numb * sizeof(bool));

size_t i;
for (i = 0; i < numb; ++i) {
for (size_t i = 0; i < numb; ++i) {
nulls[i] = false;
}

Expand Down
17 changes: 8 additions & 9 deletions src/bellman_ford/edwardMoore.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,14 +38,14 @@ PG_FUNCTION_INFO_V1(_pgr_edwardmoore);


PGDLLEXPORT Datum _pgr_edwardmoore(PG_FUNCTION_ARGS) {
FuncCallContext *funcctx;
TupleDesc tuple_desc;
FuncCallContext *funcctx = NULL;
TupleDesc tuple_desc = NULL;

Path_rt *result_tuples = NULL;
size_t result_count = 0;

if (SRF_IS_FIRSTCALL()) {
MemoryContext oldcontext;
MemoryContext oldcontext = NULL;
funcctx = SRF_FIRSTCALL_INIT();
oldcontext = MemoryContextSwitchTo(funcctx->multi_call_memory_ctx);

Expand Down Expand Up @@ -118,18 +118,17 @@ PGDLLEXPORT Datum _pgr_edwardmoore(PG_FUNCTION_ARGS) {
result_tuples = (Path_rt*) funcctx->user_fctx;

if (funcctx->call_cntr < funcctx->max_calls) {
HeapTuple tuple;
Datum result;
Datum *values;
bool* nulls;
HeapTuple tuple = NULL;
Datum result = 0;
Datum *values = NULL;
bool* nulls = NULL;
size_t call_cntr = funcctx->call_cntr;

size_t numb = 8;
values = palloc(numb * sizeof(Datum));
nulls = palloc(numb * sizeof(bool));

size_t i;
for (i = 0; i < numb; ++i) {
for (size_t i = 0; i < numb; ++i) {
nulls[i] = false;
}

Expand Down
17 changes: 8 additions & 9 deletions src/breadthFirstSearch/binaryBreadthFirstSearch.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,13 +86,13 @@ process(
}

PGDLLEXPORT Datum _pgr_binarybreadthfirstsearch(PG_FUNCTION_ARGS) {
FuncCallContext *funcctx;
TupleDesc tuple_desc;
FuncCallContext *funcctx = NULL;
TupleDesc tuple_desc = NULL;
Path_rt *result_tuples = NULL;
size_t result_count = 0;

if (SRF_IS_FIRSTCALL()) {
MemoryContext oldcontext;
MemoryContext oldcontext = NULL;
funcctx = SRF_FIRSTCALL_INIT();
oldcontext = MemoryContextSwitchTo(funcctx->multi_call_memory_ctx);

Expand Down Expand Up @@ -142,17 +142,16 @@ PGDLLEXPORT Datum _pgr_binarybreadthfirstsearch(PG_FUNCTION_ARGS) {
result_tuples = (Path_rt *)funcctx->user_fctx;

if (funcctx->call_cntr < funcctx->max_calls) {
HeapTuple tuple;
Datum result;
Datum *values;
bool *nulls;
HeapTuple tuple = NULL;
Datum result = 0;
Datum *values = NULL;
bool *nulls = NULL;

size_t numb = 8;
values = palloc(numb * sizeof(Datum));
nulls = palloc(numb * sizeof(bool));

size_t i;
for (i = 0; i < numb; ++i) {
for (size_t i = 0; i < numb; ++i) {
nulls[i] = false;
}

Expand Down
17 changes: 8 additions & 9 deletions src/breadthFirstSearch/breadthFirstSearch.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,14 +40,14 @@ PG_FUNCTION_INFO_V1(_pgr_breadthfirstsearch);


PGDLLEXPORT Datum _pgr_breadthfirstsearch(PG_FUNCTION_ARGS) {
FuncCallContext *funcctx;
TupleDesc tuple_desc;
FuncCallContext *funcctx = NULL;
TupleDesc tuple_desc = NULL;

MST_rt *result_tuples = NULL;
size_t result_count = 0;

if (SRF_IS_FIRSTCALL()) {
MemoryContext oldcontext;
MemoryContext oldcontext = NULL;
funcctx = SRF_FIRSTCALL_INIT();
oldcontext = MemoryContextSwitchTo(funcctx->multi_call_memory_ctx);

Expand Down Expand Up @@ -84,18 +84,17 @@ PGDLLEXPORT Datum _pgr_breadthfirstsearch(PG_FUNCTION_ARGS) {
result_tuples = (MST_rt*) funcctx->user_fctx;

if (funcctx->call_cntr < funcctx->max_calls) {
HeapTuple tuple;
Datum result;
Datum *values;
bool* nulls;
HeapTuple tuple = NULL;
Datum result = 0;
Datum *values = NULL;
bool* nulls = NULL;

size_t num = 8;
values = palloc(num * sizeof(Datum));
nulls = palloc(num * sizeof(bool));


size_t i;
for (i = 0; i < num; ++i) {
for (size_t i = 0; i < num; ++i) {
nulls[i] = false;
}

Expand Down
Loading