Skip to content

clang-tiddy: add cppcoreguidelines-interfaces-global-init #3004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cvvergara merged 10 commits into from
May 1, 2026
+5 −6
Merged

clang-tiddy: add cppcoreguidelines-interfaces-global-init #3004

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ec85f2e
clang.tiddy: add cppcoreguidelines-interfaces-global-init
akronim26 Dec 18, 2025
ebc9116
clang-tidy: add cppcoreguidelines-rvalue-reference-param-not-moved
akronim26 Dec 18, 2025
1ab8e26
clang-tidy: add cppcoreguidelines-pro-type-member-init & fixed minCos…
akronim26 Dec 18, 2025
bf2cca1
fix warnings in path.hpp
akronim26 Dec 26, 2025
632973f
remove redundant initialization in include/common/path.hpp
akronim26 Dec 26, 2025
648184d
remove cppcoreguidelines-pro-type-member-init from .clang-tidy
akronim26 Dec 27, 2025
dd67e4f
remove the trailing comma from the concerned line
akronim26 Jan 5, 2026
ea983c3
Merge branch 'develop' into akronim26-cpp
akronim26 Jan 5, 2026
aba9f82
Merge branch 'develop' into akronim26-cpp
akronim26 Jan 8, 2026
9caf7bf
Merge branch 'develop' into akronim26-cpp
cvvergara May 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .clang-tidy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,10 @@ Checks: >
cppcoreguidelines-avoid-capturing-lambda-coroutines,
cppcoreguidelines-avoid-goto,
cppcoreguidelines-avoid-non-const-global-variables,
cppcoreguidelines-avoid-reference-coroutine-parameters
cppcoreguidelines-avoid-reference-coroutine-parameters,
cppcoreguidelines-interfaces-global-init,
Copy link
Copy Markdown
Member

@cvvergara cvvergara Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the trailing comma

cppcoreguidelines-rvalue-reference-param-not-moved,
cppcoreguidelines-pro-type-member-init
Comment thread
cvvergara marked this conversation as resolved.
Outdated

WarningsAsErrors: ''
HeaderFilterRegex: './include'
Expand Down
4 changes: 2 additions & 2 deletions include/cpp_common/path.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,10 +59,10 @@ class Path {
std::deque< Path_t > path;
int64_t m_start_id;
int64_t m_end_id;
double m_tot_cost;
double m_tot_cost{0};
Comment thread
coderabbitai[bot] marked this conversation as resolved.

public:
Path(): m_start_id(0), m_end_id(0), m_tot_cost(0)
Path() : m_start_id(0), m_end_id(0), m_tot_cost(0)
{}
Path(int64_t s_id, int64_t e_id)
: m_start_id(s_id), m_end_id(e_id), m_tot_cost(0)
Expand Down
2 changes: 1 addition & 1 deletion src/max_flow/minCostMaxFlow.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ PgrCostFlowGraph::GetFlowEdges() const {
if (((capacity[*e] - residual_capacity[*e]) > 0) &&
((*e).m_source != supersource) &&
((*e).m_target != supersink)) {
Flow_t edge;
Flow_t edge{};
edge.edge = GetEdgeId(*e);
edge.source = GetVertexId((*e).m_source);
edge.target = GetVertexId((*e).m_target);
Expand Down