SPOCK-625: bump extension version to 2.6.0#42
Conversation
The v2.6.0 tag was cut without bumping the extension version metadata: snowflake.control still declared default_version = '2.5.0' and no 2.6.0 SQL script existed, so the extension installed and reported itself as 2.5.0 even when built from the v2.6.0 tag. - snowflake.control: default_version 2.5.0 -> 2.6.0 - add snowflake--2.5.0--2.6.0.sql upgrade script (2.6.0 is the Postgres 19 port, a C/build change with no catalog changes) - Makefile: add the upgrade script to DATA - add test/t/snowflake_version.py regression guarding the version metadata, registered in the script_file schedule Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
📝 WalkthroughWalkthroughChangesVersion upgrade
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| Compatibility | 2 high (1 false positive) |
| Security | 1 minor (1 false positive) |
🟢 Metrics 0 complexity · 0 duplication
Metric Results Complexity 0 Duplication 0
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
test/t/snowflake_version.py (1)
63-65: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winUpdate misleading error message.
The error message explicitly mentions
(no snowflake--{EXPECTED_VERSION}.sql), which implies a base installation script is required. However, theMakefiledoes not include a basesnowflake--2.6.0.sqlscript—PostgreSQL also considers a version offered if it can be reached by chaining upgrade scripts (e.g.,snowflake--2.5.0--2.6.0.sql). Consider updating the message to avoid misdirecting developers if the test ever fails.💡 Proposed fix
- failures.append( - f"'{EXPECTED_VERSION}' is not an offered version (no snowflake--{EXPECTED_VERSION}.sql); " - f"offered: {offered}") + failures.append( + f"'{EXPECTED_VERSION}' is not an offered version (missing base or upgrade script); " + f"offered: {offered}")🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@test/t/snowflake_version.py` around lines 63 - 65, Update the failure message in the version-offering check that appends to failures so it no longer claims a base snowflake--EXPECTED_VERSION.sql script is required. Describe the version as unavailable among the offered or reachable upgrade versions, while preserving the offered versions output.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@test/t/snowflake_version.py`:
- Around line 63-65: Update the failure message in the version-offering check
that appends to failures so it no longer claims a base
snowflake--EXPECTED_VERSION.sql script is required. Describe the version as
unavailable among the offered or reachable upgrade versions, while preserving
the offered versions output.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 071a0fad-9739-4141-a0df-9e766bb403da
📒 Files selected for processing (5)
Makefilesnowflake--2.5.0--2.6.0.sqlsnowflake.controltest/schedule_files/script_filetest/t/snowflake_version.py
| -- complain if script is sourced in psql, rather than via ALTER EXTENSION | ||
| \echo Use "ALTER EXTENSION snowflake UPDATE TO '2.6.0'" to load this file. \quit | ||
|
|
||
| -- ---------------------------------------------------------------------- |
There was a problem hiding this comment.
Remove this comment block. If using AI, it tends to write overly verbose and superfluous comments.
| @@ -1 +1,2 @@ | |||
| test/t/temp.sh | |||
| test/t/snowflake_version.py | |||
There was a problem hiding this comment.
We don't want to run this in the schedule
| @@ -0,0 +1,94 @@ | |||
| import sys, os, json, util_test, subprocess | |||
There was a problem hiding this comment.
Remove this test, just makes extra maintenance work
2 participants
The v2.6.0 tag was cut without bumping the extension version metadata: snowflake.control still declared default_version = '2.5.0' and no 2.6.0 SQL script existed, so the extension installed and reported itself as 2.5.0 even when built from the v2.6.0 tag.