Skip to content

chore: support IPv6 fallback in IP autodetection #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GabriellePoncey wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: support IPv6 fallback in IP autodetection #423

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 12 additions & 9 deletions server/internal/config/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,12 +433,13 @@ func defaultAddresses() ([]string, error) {
return []string{ip.String()}, nil
}

// getFirstIP gets the first non-loopback IPv4 address
// getFirstIP gets the first non-loopback IP address, preferring IPv4.
func getFirstIP() (net.IP, error) {
interfaces, err := net.Interfaces()
if err != nil {
return net.IPv4zero, fmt.Errorf("failed to list interfaces: %w", err)
}
var ipv6 net.IP
for _, iface := range interfaces {
// Skip loopback and down interfaces
if iface.Flags&net.FlagLoopback != 0 || iface.Flags&net.FlagUp == 0 {
Expand All @@ -448,7 +449,6 @@ func getFirstIP() (net.IP, error) {
if err != nil {
continue
}

for _, addr := range addrs {
var ip net.IP
switch v := addr.(type) {
Expand All @@ -458,21 +458,24 @@ func getFirstIP() (net.IP, error) {
ip = v.IP
}

// Check if it is a valid IPv4 address and not a loopback address
// Check if it is a valid address and not a loopback address
if ip == nil || ip.IsLoopback() {
continue
}

// To4() returns nil if the IP is not an IPv4 address
ip = ip.To4()
if ip == nil {
continue
if v4 := ip.To4(); v4 != nil {
return v4, nil
}
// Store first IPv6 address found, keep searching for IPv4
if ipv6 == nil {
ipv6 = ip.To16()
}

// Return the first valid IPv4 address found
return ip, nil
}
}
if ipv6 != nil {
return ipv6, nil
}

return net.IPv4zero, fmt.Errorf("could not find a valid network interface")
}
Expand Down