Resolve code coverage ReportRoot and RepoRoot during configuration validation - #2940
Merged
Conversation
…guration validation CodeCoverage.ReportRoot and Run.RepoRoot were resolved to absolute paths only in Get-ReportRoot, which runs when the report is written at the very end of the run. A test can change the current location (Set-Location), so a relative ReportRoot/RepoRoot resolved then would use whatever directory the last test left behind (#2921 comment). Resolve both to absolute in Resolve-CodeCoverageConfiguration, which runs during plugin setup while the current location still points at the directory Invoke-Pester was called from, next to the OutputPath resolution added in #2892. Paths already absolute are unaffected. 🤖
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #2923
CodeCoverage.ReportRootandRun.RepoRootwere resolved to absolute paths too late, so a working-directory change during the run resolved them against the wrong location. Now they are resolved and validated during configuration validation, before any test code runs, following #2921 and #2892.🤖