Skip to content

Remove coverageGutters, make coverage relative to repo root, add repo root#2683

Open
nohwnd wants to merge 13 commits intomainfrom
repo-root-coverage
Open

Remove coverageGutters, make coverage relative to repo root, add repo root#2683
nohwnd wants to merge 13 commits intomainfrom
repo-root-coverage

Conversation

@nohwnd
Copy link
Member

@nohwnd nohwnd commented Mar 16, 2026

PR Summary

Add detection of repository root, to find a common path for reports and potentially other stuff. Simply look for .git folder, which is a common way we do it in other repos that works well, and .git is basically used everywhere. If not found use the working directory, which is most often the repo root anyway. User can override the value if it does not work for them. It allows CI tools to work well, because they usually care about relative paths to the checkout directory, without forcing all paths to absolute.

Remove CoverageGutters format from coverage, because it was just JaCoCo with the paths correctly formed against coverage.xml location, which was in the repo root.

Removes the "get common folder" function which returns result dependent on the files you provided to the coverage in non-obvious way.

Fix #2668

PR Checklist

  • PR has meaningful title
  • [ x Summary describes changes
  • PR is ready to be merged
    • If not, use the arrow next to Create Pull Request to mark it as a draft. PR can be marked Ready for review when it's ready.
  • Tests are added/update (if required)
  • Documentation is updated/added (if required)

@nohwnd nohwnd added the New default in 6.0 A new option in 5, that will switch to new default in 6. label Mar 16, 2026
@nohwnd
Copy link
Member Author

nohwnd commented Mar 16, 2026

There are 2 new options, run.repoRoot, and coverage.reportRoot, not sure if making the names similar is genius or stupid. But I like both names.

@nohwnd nohwnd added this to the 6.0.0 milestone Mar 16, 2026
@nohwnd
Copy link
Member Author

nohwnd commented Mar 18, 2026

finally green in case you want to have a look @fflaten

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

New default in 6.0 A new option in 5, that will switch to new default in 6.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Filenames in JaCoCo report seem to be wrong

1 participant