Remove coverageGutters, make coverage relative to repo root, add repo root#2683
Open
Remove coverageGutters, make coverage relative to repo root, add repo root#2683
Conversation
Member
Author
|
There are 2 new options, run.repoRoot, and coverage.reportRoot, not sure if making the names similar is genius or stupid. But I like both names. |
Member
Author
|
finally green in case you want to have a look @fflaten |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Add detection of repository root, to find a common path for reports and potentially other stuff. Simply look for .git folder, which is a common way we do it in other repos that works well, and .git is basically used everywhere. If not found use the working directory, which is most often the repo root anyway. User can override the value if it does not work for them. It allows CI tools to work well, because they usually care about relative paths to the checkout directory, without forcing all paths to absolute.
Remove CoverageGutters format from coverage, because it was just JaCoCo with the paths correctly formed against coverage.xml location, which was in the repo root.
Removes the "get common folder" function which returns result dependent on the files you provided to the coverage in non-obvious way.
Fix #2668
PR Checklist
Create Pull Requestto mark it as a draft. PR can be markedReady for reviewwhen it's ready.