Skip to content

[IGNORE] Move from Jest to Vitest - #776

Open
Gladorme wants to merge 1 commit into
perses:mainfrom
Gladorme:vitest-v4
Open

[IGNORE] Move from Jest to Vitest#776
Gladorme wants to merge 1 commit into
perses:mainfrom
Gladorme:vitest-v4

Conversation

@Gladorme

Copy link
Copy Markdown
Member

Description

Last repo to move from Jest to Vitest following previous PR:

Screenshots

Checklist

  • Pull request has a descriptive title and context useful to a reviewer.
  • Pull request title follows the [<catalog_entry>] <commit message> naming convention using one of the
    following catalog_entry values: FEATURE, ENHANCEMENT, BUGFIX, BREAKINGCHANGE, DOC,IGNORE.
  • All commits have DCO signoffs.

UI Changes

  • Changes that impact the UI include screenshots and/or screencasts of the relevant changes.
  • Code follows the UI guidelines.

@Gladorme
Gladorme force-pushed the vitest-v4 branch 2 times, most recently from 8def47f to d5cece2 Compare August 22, 2026 01:12
Comment thread vitest.shared.ts
resolve: {
alias: [
{
find: /^@perses-dev\/(client|components|core|dashboards|explore|plugin-system|spec)$/,

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested removing it. Got error:

  • ScatterChart: No QueryClient set
  • Table: Virtuoso context was duplicated, so rows did not render

IA reason:
The published @perses-dev/* packages currently expose CommonJS and ESM. Vitest ends up loading both module variants, creating separate React contexts. The regex alias forces one ESM instance.

I guess it will be removed once we move to ESM only, probably really soon. Next thing I want to do with upgrading to Node 24 (LTS)

Signed-off-by: Guillaume <gladorme@gmail.com>
@Gladorme
Gladorme marked this pull request as ready for review August 22, 2026 01:47
@Gladorme
Gladorme requested review from a team and andreasgerstmayr as code owners August 22, 2026 01:47
@Gladorme
Gladorme requested review from shahrokni and removed request for a team August 22, 2026 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant