Skip to content

[BUGFIX] migration of datasource selector when it's a datasource var ref - #775

Draft
celian-garcia wants to merge 1 commit into
mainfrom
celian-garcia/fix-stat-chart
Draft

[BUGFIX] migration of datasource selector when it's a datasource var ref#775
celian-garcia wants to merge 1 commit into
mainfrom
celian-garcia/fix-stat-chart

Conversation

@celian-garcia

@celian-garcia celian-garcia commented Aug 20, 2026

Copy link
Copy Markdown
Member

Description

When datasource selector contains a reference to a datasource variable, the syntax is "datasource": "${datasource}", and not the current migration result:

"datasource": {
      "kind": "PrometheusDatasource",
      "name": "${datasource}"
    },

This PR fixes that problem and remove an unused variable.


Note that we need this PR merged perses/shared#242 and a shared package update , so it will also support the ${} syntax and the test will pass.

This is why the tests are failing

Screenshots

Checklist

  • Pull request has a descriptive title and context useful to a reviewer.
  • Pull request title follows the [<catalog_entry>] <commit message> naming convention using one of the
    following catalog_entry values: FEATURE, ENHANCEMENT, BUGFIX, BREAKINGCHANGE, DOC,IGNORE.
  • All commits have DCO signoffs.

@celian-garcia
celian-garcia force-pushed the celian-garcia/fix-stat-chart branch 3 times, most recently from 9bd6472 to 94d5b3e Compare August 21, 2026 09:57
@celian-garcia celian-garcia changed the title [ENHANCEMENT] Support migration of curly braces ${} variable syntax in datasource selector shortcut [BUGFIX] migration of datasource selector when it's a datasource var ref Aug 21, 2026
Signed-off-by: Celian GARCIA <celian.garcia@amadeus.com>
@celian-garcia
celian-garcia force-pushed the celian-garcia/fix-stat-chart branch from 94d5b3e to cdcd77d Compare August 21, 2026 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant