You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
fix: improve error handling and logging in EventBroadcaster
Add dedicated connection method with proper error handling and logging
Improve error visibility by logging connection failures at ERROR level
Add more descriptive error messages including problematic URLs
This improves visibility of broadcast connection issues like DNS resolution failures
that were previously being swallowed. Fixes issue where typos in broadcast URIs
could go unnoticed due to insufficient error logging.
Hi @daveads - thanks for your efforts here - much appreciated.
While the code seems okay - I don't think this is the right way to approach permitio/opal#716 and permitio/opal#711 ;
As the issue here isn't that this library (fastapi_websocket_pubsub) is swallowing the errors- but that the OPAL code using it is / is using the wrong log level for communicating them.
In addition the tests are currently hanging / failing.
I'd advise closing this PR and addressing the issues in OPAL itself
Hi @daveads - thanks for your efforts here - much appreciated. While the code seems okay - I don't think this is the right way to approach permitio/opal#716 and permitio/opal#711 ; As the issue here isn't that this library (fastapi_websocket_pubsub) is swallowing the errors- but that the OPAL code using it is / is using the wrong log level for communicating them.
In addition the tests are currently hanging / failing. I'd advise closing this PR and addressing the issues in OPAL itself
In that case I'd need to ask @obsd and @danyi1212 to look at them
sure...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: improve error handling and logging in EventBroadcaster
This improves visibility of broadcast connection issues like DNS resolution failures
that were previously being swallowed. Fixes issue where typos in broadcast URIs
could go unnoticed due to insufficient error logging.
permitio/opal#716