allow analyser to be run by specified dimension in configuration#47
Open
allow analyser to be run by specified dimension in configuration#47
Conversation
…ate directory in generator when it does not exsit.
Codecov Report
@@ Coverage Diff @@
## master #47 +/- ##
==========================================
- Coverage 82.55% 81.00% -1.56%
==========================================
Files 50 51 +1
Lines 2345 2437 +92
==========================================
+ Hits 1936 1974 +38
- Misses 409 463 +54
Continue to review full report at Codecov.
|
| if not os.path.isdir(self.__services.resources.maps_dir._full_path() + atlas_name + dimensions_path): | ||
| os.mkdir(self.__services.resources.maps_dir._full_path() + atlas_name + dimensions_path) | ||
|
|
||
| with open(self.__services.resources.maps_dir._full_path() + atlas_name + dimensions_path + '/' + str(_) + dimensions_path + '.json', 'w') as outfile: |
Member
There was a problem hiding this comment.
These file paths are dodgy, prevents portability across platforms.
judicaelclair
previously approved these changes
Dec 26, 2020
Nabushika
requested changes
Dec 28, 2020
Collaborator
Nabushika
left a comment
Nabushika
left a comment
There was a problem hiding this comment.
Please clean this up, 400+ files changed? Take care of what you commit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
allow analyser to be run by specified dimension in configuration, create directory in generator when it does not exsit.