Skip to content

Comments

K8SPG-908: use official postgis images#1455

Draft
pooknull wants to merge 2 commits intomainfrom
K8SPG-908
Draft

K8SPG-908: use official postgis images#1455
pooknull wants to merge 2 commits intomainfrom
K8SPG-908

Conversation

@pooknull
Copy link
Contributor

https://perconadev.atlassian.net/browse/K8SPG-908

CHANGE DESCRIPTION

Problem:
Short explanation of the problem.

Cause:
Short explanation of the root cause of the issue if applicable.

Solution:
Short explanation of the solution we are providing with this PR.

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?
  • Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
  • Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

  • Is an E2E test/test case added for the new feature/change?
  • Are unit tests added where appropriate?

Config/Logging/Testability

  • Are all needed new/changed options added to default YAML files?
  • Are all needed new/changed options added to the Helm Chart?
  • Did we add proper logging messages for operator actions?
  • Did we ensure compatibility with the previous version or cluster upgrade process?
  • Does the change support oldest and newest supported PG version?
  • Does the change support oldest and newest supported Kubernetes version?

Copilot AI review requested due to automatic review settings February 18, 2026 11:41
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates example manifests and E2E image/version inputs to use the percona-distribution-postgresql-with-postgis image (instead of operator-built PostGIS variants), aligning PostGIS usage with the distribution image approach.

Changes:

  • Switch PostGIS image references in sample CRs and upgrade manifest to percona-distribution-postgresql-with-postgis.
  • Update e2e-tests/release_versions to use distribution PostGIS images for PG 17/18.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
percona/controller/testdata/sidecar-resources-cr.yaml Updates test CR to use distribution PostGIS image for PG17.
e2e-tests/release_versions Updates PostGIS image tags used by E2E runs (PG17/PG18).
deploy/upgrade.yaml Updates upgrade example to use distribution PostGIS image as the target PG image.
deploy/cr.yaml Updates example CR to use distribution PostGIS image for PG17.

IMAGE_POSTGRESQL17=percona/percona-distribution-postgresql:17.7-2
IMAGE_PGBOUNCER17=percona/percona-pgbouncer:1.25.0-1
IMAGE_POSTGIS17=percona/percona-postgresql-operator:2.8.2-ppg17.7-postgres-gis3.3.8
IMAGE_POSTGIS17=percona/percona-distribution-postgresql-with-postgis:17.7
Copy link

Copilot AI Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Problem: IMAGE_POSTGIS17 uses :17.7 while the corresponding PostgreSQL image uses :17.7-2 (and PG18 PostGIS matches 18.1-3), so this looks like an inconsistent/possibly incorrect tag.
  2. Why it matters: If :17.7 isn’t a published tag, E2E runs that select the PostGIS 17 image will fail when pulling images.
  3. Fix: Align the PostGIS 17 tag format with the repo’s versioning pattern (likely 17.7-2 to match IMAGE_POSTGRESQL17), or confirm/update to the exact existing tag in the registry.
Suggested change
IMAGE_POSTGIS17=percona/percona-distribution-postgresql-with-postgis:17.7
IMAGE_POSTGIS17=percona/percona-distribution-postgresql-with-postgis:17.7-2

Copilot uses AI. Check for mistakes.
crVersion: 2.9.0

image: perconalab/percona-postgresql-operator:main-ppg17-postgres
image: docker.io/perconalab/percona-distribution-postgresql-with-postgis:17
Copy link

Copilot AI Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Problem: There are two spaces after image: (image: docker.io/...).
  2. Why it matters: While valid YAML, inconsistent whitespace in testdata makes diffs/noise harder to read and can be problematic if any tooling does raw text comparisons.
  3. Fix: Use a single space after the colon (image: docker.io/...) for consistency with the rest of the YAML examples.
Suggested change
image: docker.io/perconalab/percona-distribution-postgresql-with-postgis:17
image: docker.io/perconalab/percona-distribution-postgresql-with-postgis:17

Copilot uses AI. Check for mistakes.
@egegunes egegunes added this to the v2.9.0 milestone Feb 19, 2026
@JNKPercona
Copy link
Collaborator

Test Name Result Time
backup-enable-disable passed 00:05:58
builtin-extensions passed 00:05:16
custom-envs passed 00:18:47
custom-extensions passed 00:13:34
custom-tls passed 00:05:10
database-init-sql passed 00:02:18
demand-backup passed 00:24:26
demand-backup-offline-snapshot passed 00:12:15
dynamic-configuration passed 00:03:06
finalizers passed 00:03:46
init-deploy passed 00:03:12
huge-pages passed 00:02:48
monitoring passed 00:06:43
monitoring-pmm3 passed 00:07:46
one-pod passed 00:05:53
operator-self-healing passed 00:10:05
pitr passed 00:11:29
scaling passed 00:04:50
scheduled-backup passed 00:27:18
self-healing passed 00:08:56
sidecars passed 00:02:32
standby-pgbackrest passed 00:11:47
standby-streaming passed 00:09:17
start-from-backup passed 00:10:37
tablespaces passed 00:06:49
telemetry-transfer passed 00:04:36
upgrade-consistency passed 00:06:31
upgrade-minor passed 00:06:15
users passed 00:04:32
Summary Value
Tests Run 29/29
Job Duration 01:18:09
Total Test Time 04:06:46

commit: c27e166
image: perconalab/percona-postgresql-operator:PR-1455-c27e16644

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants