Conversation
There was a problem hiding this comment.
Pull request overview
Updates example manifests and E2E image/version inputs to use the percona-distribution-postgresql-with-postgis image (instead of operator-built PostGIS variants), aligning PostGIS usage with the distribution image approach.
Changes:
- Switch PostGIS image references in sample CRs and upgrade manifest to
percona-distribution-postgresql-with-postgis. - Update
e2e-tests/release_versionsto use distribution PostGIS images for PG 17/18.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| percona/controller/testdata/sidecar-resources-cr.yaml | Updates test CR to use distribution PostGIS image for PG17. |
| e2e-tests/release_versions | Updates PostGIS image tags used by E2E runs (PG17/PG18). |
| deploy/upgrade.yaml | Updates upgrade example to use distribution PostGIS image as the target PG image. |
| deploy/cr.yaml | Updates example CR to use distribution PostGIS image for PG17. |
| IMAGE_POSTGRESQL17=percona/percona-distribution-postgresql:17.7-2 | ||
| IMAGE_PGBOUNCER17=percona/percona-pgbouncer:1.25.0-1 | ||
| IMAGE_POSTGIS17=percona/percona-postgresql-operator:2.8.2-ppg17.7-postgres-gis3.3.8 | ||
| IMAGE_POSTGIS17=percona/percona-distribution-postgresql-with-postgis:17.7 |
There was a problem hiding this comment.
- Problem:
IMAGE_POSTGIS17uses:17.7while the corresponding PostgreSQL image uses:17.7-2(and PG18 PostGIS matches18.1-3), so this looks like an inconsistent/possibly incorrect tag. - Why it matters: If
:17.7isn’t a published tag, E2E runs that select the PostGIS 17 image will fail when pulling images. - Fix: Align the PostGIS 17 tag format with the repo’s versioning pattern (likely
17.7-2to matchIMAGE_POSTGRESQL17), or confirm/update to the exact existing tag in the registry.
Suggested change
| IMAGE_POSTGIS17=percona/percona-distribution-postgresql-with-postgis:17.7 | |
| IMAGE_POSTGIS17=percona/percona-distribution-postgresql-with-postgis:17.7-2 |
| crVersion: 2.9.0 | ||
|
|
||
| image: perconalab/percona-postgresql-operator:main-ppg17-postgres | ||
| image: docker.io/perconalab/percona-distribution-postgresql-with-postgis:17 |
There was a problem hiding this comment.
- Problem: There are two spaces after
image:(image: docker.io/...). - Why it matters: While valid YAML, inconsistent whitespace in testdata makes diffs/noise harder to read and can be problematic if any tooling does raw text comparisons.
- Fix: Use a single space after the colon (
image: docker.io/...) for consistency with the rest of the YAML examples.
Suggested change
| image: docker.io/perconalab/percona-distribution-postgresql-with-postgis:17 | |
| image: docker.io/perconalab/percona-distribution-postgresql-with-postgis:17 |
Collaborator
commit: c27e166 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://perconadev.atlassian.net/browse/K8SPG-908
CHANGE DESCRIPTION
Problem:
Short explanation of the problem.
Cause:
Short explanation of the root cause of the issue if applicable.
Solution:
Short explanation of the solution we are providing with this PR.
CHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
Config/Logging/Testability