Skip to content

fix: backwards-compat timestamp, safe eviction sort, aligned test batch size #1192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ebma merged 2 commits into from
Jun 3, 2026
Merged

fix: backwards-compat timestamp, safe eviction sort, aligned test batch size #1192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
75d7420
Initial plan
Copilot Jun 3, 2026
4f77d21
fix: make timestamp optional in RampEphemeralEntry, use optional chai…
Copilot Jun 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/api/src/api/services/ramp/base.service.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import QuoteTicket from "../../../models/quoteTicket.model";
import {BaseRampService} from "./base.service";

const transaction = { id: "cleanup-test-transaction" };
const expectedDeleteBatchSize = 500;
const expectedDeleteBatchSize = 5000;

type QuoteCleanupWhere = {
expiresAt?: {
Expand Down
4 changes: 2 additions & 2 deletions apps/frontend/src/contexts/rampState.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ const MAX_RAMP_EPHEMERALS = 50;
type RampEphemeralEntry = {
substrateEphemeral: EphemeralAccount;
evmEphemeral: EphemeralAccount;
timestamp: number;
timestamp?: number;
};
type RampEphemeralsMap = Record<string, RampEphemeralEntry>;

Expand All @@ -32,7 +32,7 @@ export function updateRampEphemeral(rampId: string, ephemerals: RampExecutionInp

const keys = Object.keys(existing);
if (keys.length > MAX_RAMP_EPHEMERALS) {
const sorted = keys.sort((a, b) => (existing[a].timestamp ?? 0) - (existing[b].timestamp ?? 0));
const sorted = keys.sort((a, b) => (existing[a]?.timestamp ?? 0) - (existing[b]?.timestamp ?? 0));
const toRemove = sorted.slice(0, sorted.length - MAX_RAMP_EPHEMERALS);
for (const key of toRemove) {
delete existing[key];
Expand Down
Loading