Closed
Conversation
MMC_sync was especially dangerous, as some cards don't like being selected and immediately deselected w/o any transmitted data. ref: https://dmitry.gr/?r=05.Projects&proj=36.%208pinLinux#_TOC_e23710bba70063c2e153d50ddbe4a51c
As per Part 1 of the SD Spec, the initial clock can be anything from 100 to 400KHz. Setting it to 400KHz may slightly improve the bootup time, and there are no downsides.
Owner
|
I've (finally) pulled these all in, with the exception of aa5643e - you forgot that rcvr_mmc sends 8 clocks per byte :) Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some minor improvements to the SD handling code, which should drastically improve the performance (~23% faster on read, ~10% faster on write; measured through USB mass storage mode with
dd conv=fsyncon a plenty fast SanDisk 8GB SDHC card.results may vary, no guarantees :p
Biggest bottleneck seems to be USB, but I bet we could squeeze 20-40% more performance on both read and write if we migrated away from the blocking SPI calls. Increasing the SD clock beyond the default 20MHz didn't make a significant difference, which leads me to believe that the majority of the time is wasted on copying data with blocking calls.