Skip to content

Add sortable feature to name column in ListServers#2282

Merged
lancepioch merged 2 commits intopelican-dev:mainfrom
julianbenz:patch-1
Apr 8, 2026
Merged

Add sortable feature to name column in ListServers#2282
lancepioch merged 2 commits intopelican-dev:mainfrom
julianbenz:patch-1

Conversation

@julianbenz
Copy link
Copy Markdown
Contributor

Possibility to sort the server in the list after name

Possibility to sort the server in the list after name
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 25, 2026

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 25, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: e4da76ca-ab6a-4872-9cbe-29e030d78e47

📥 Commits

Reviewing files that changed from the base of the PR and between fbf1ba7 and be2c908.

📒 Files selected for processing (1)
  • app/Filament/App/Resources/Servers/Pages/ListServers.php
✅ Files skipped from review due to trivial changes (1)
  • app/Filament/App/Resources/Servers/Pages/ListServers.php

📝 Walkthrough

Walkthrough

Added .sortable() to the name table column in the servers list, enabling sorting on that column where previously only searching was configured.

Changes

Cohort / File(s) Summary
Table Column Sorting
app/Filament/App/Resources/Servers/Pages/ListServers.php
Updated the name column configuration: appended ->sortable() after ->searchable() to enable column sorting. No other table sort configuration was changed.
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding a sortable feature to the name column in ListServers, which matches the changeset summary.
Description check ✅ Passed The description is directly related to the changeset, explaining the purpose of adding sorting capability for servers by name in the list view.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@julianbenz
Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA

Comment thread app/Filament/App/Resources/Servers/Pages/ListServers.php Outdated
Removed default sorting by 'name' in the server list.
@lancepioch lancepioch merged commit e01d9f2 into pelican-dev:main Apr 8, 2026
17 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants