Add thread safety and lifecycle for native pointers#70
Open
edde746 wants to merge 2 commits intopeerless2012:masterfrom
Open
Add thread safety and lifecycle for native pointers#70edde746 wants to merge 2 commits intopeerless2012:masterfrom
edde746 wants to merge 2 commits intopeerless2012:masterfrom
Conversation
Contributor
|
I believe to be properly thread safe, any call to libass should use the same mutex. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
release()methods toAss,AssTrack, andAssRender(replaces GC-onlyfinalize()cleanup)ReentrantLockinAssRenderto synchronizerenderFrame,setTrack, andreleaseAssHandler.readTrackDialogue()with the render lock to prevent concurrentass_process_chunk/ass_render_frameon the same trackAssHandler.release()for explicit native resource cleanupContext
Google Play Console reports native crashes in
libass.so(ass_parse_tags,ass_render_frame) caused by concurrent thread access toASS_Track*and null/freed native pointers.