fix: set .bestpractices.json dynamic_analysis to Met (N/A not allowed)#91
Merged
Merged
Conversation
The dynamic_analysis criterion has no na_allowed flag in the BadgeApp (unlike dynamic_analysis_unsafe), so a value of "N/A" fails validation with "Dynamic analysis status is not included in the list" when saving a section. The project does apply a dynamic analysis tool — Go native fuzzing (internal/match/fuzz_test.go, internal/ui/printer_fuzz_test.go) — so Met is the accurate, accepted answer. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #90.
Saving a section on bestpractices.dev failed with "Dynamic analysis status is not included in the list". Cause: the
dynamic_analysiscriterion has nona_allowedflag in the BadgeApp'scriteria.yml(only its siblingdynamic_analysis_unsafedoes), so"N/A"is not an accepted value — it only allowsMet/Unmet/?.The project does apply a dynamic-analysis tool — Go native fuzzing (
internal/match/fuzz_test.go,internal/ui/printer_fuzz_test.go) — soMetis the accurate and accepted answer.🤖 Generated with Claude Code