fix: Calculate end delay for non-seekable ogg streams #407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aschey
changed the title
aschey
commented
Oct 10, 2025
| if self.end_bound.is_some() { | ||
| debug!("end page already found"); | ||
| return state; | ||
| return; |
Contributor
Author
There was a problem hiding this comment.
I removed the debug log here since this case could be hit a lot more often now. Seemed like it would be more spammy than useful.
aschey
force-pushed
the
fix/ogg-stream-gapless
branch
from
cae6bc5 to
ce6c9f2
Compare
aschey
force-pushed
the
fix/ogg-stream-gapless
branch
from
ce6c9f2 to
ce43d9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #404.
Currently, the end delay for ogg streams is only calculated for seekable streams. This can cause discontinuities for non-seekable streams like internet radio that are designed to play gaplessly. Calling
inspect_end_pagefor every page that's read ensures the end delay is still calculated for non-seekable streams. If the end delay was calculated previously, this is a no-op because of the check forself.end_bound.is_some()at the beginning ofinspect_end_page.InspectStatewas also moved to a struct field since the value needs to persist through multiple calls toread_page.