Allow mid-stream starting of flac streams.#390
Open
GeoffClements wants to merge 3 commits intopdeljanov:dev-0.6from
Open
Allow mid-stream starting of flac streams.#390GeoffClements wants to merge 3 commits intopdeljanov:dev-0.6from
GeoffClements wants to merge 3 commits intopdeljanov:dev-0.6from
Conversation
Contributor
|
Please make PR into the dev branch |
Author
Apologies, I'm a bit of a PR noob, this is my second ever. |
Contributor
|
No problem. You can still reduce the number of changed lines and name the commits accordingly by following the contributing guide. I don't remember exactly, but I think fmt should be used from the nightly version. |
GeoffClements
force-pushed
the
flac-skip
branch
from
e33697e to
61fa2c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to issue: #372
This change affects
symphonia-bundle-flaconly. It adds the ability for Symphonia to create aFlacReaderandFlacDecoderwhen presented with a stream that starts at a random position.Normal stream starts, i.e. when the marker "fLaC" is present, are unaffected by this change.
A new branch,
flac-skiphas been created to isolate this change, this was branched off thedev-0.6branch.All checks are passing.