Skip to content

Hoist lints from individual packages to workspace#336

Closed
caass wants to merge 21 commits intopdeljanov:dev-0.6from
caass:caass/hoist-lints
Closed

Hoist lints from individual packages to workspace#336
caass wants to merge 21 commits intopdeljanov:dev-0.6from
caass:caass/hoist-lints

Conversation

@caass
Copy link
Copy Markdown

@caass caass commented Jan 3, 2025

By hoisting the lint settings out from individual packages to the root Cargo.toml (and using lints.workspace = true in the individual crates), lints can be applied uniformly across all crates.

@pdeljanov
Copy link
Copy Markdown
Owner

Thanks, for this!

I'm glad this option exists to make things more consistent across all of our crates. It looks like symphonia-core wasn't using #![warn(rust_2018_idioms)] like all the other crates and it's causing the CI errors. Do you want to fix those?

@pdeljanov
Copy link
Copy Markdown
Owner

Closing due to inactivity.

@pdeljanov pdeljanov closed this Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants