Draft
Conversation
Tests passing on 9.2.8, 9.4.8, 9.6.7, 9.8.4, 9.10.1, 9.12.2 Clean hie.yaml Fix os-string-io provenance Fix haskell-ci haskell-ci regenerate --installed=-process Adjust build-depends bounds and remove support to ghc <8.6 Use text
Author
|
@HuwCampbell hi, sorry for the ping. Is OsString support planned? or should it be better to make a different package? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
String)process >= 1.6.26.0). Also, as mentioned in Support for ospath/osstring #491,filepath >= 1.5andos-string >= 2.0.5are needed.ghcas mentioned in Support for ospath/osstring #491.textis already a transitive dependency, so I also updated some of the API to use that instead ofString.prettyprinterisLazyTextI've updated the API to not change this type.Text.IOfunctions for printing.unsafePerformIO . decodeLE, but also new functionsOptions.Applicative.Help.Pretty.osStringToStrictText(built in terms ofByteString -> Textfunctions). It would be nice if there was a straightOsString -> Text, instead of the need to pass throughStringorByteString.Options.Applicative.Help.Levenshteinas-is (usingString), but theOptions.Applicative.Builder.Completer(which has heavy use ofuncons) module is updated, it's expected thatLevenshteinwould look likeCompleter.OsString.getProgNameandOsString.readProcessinprocess.