Skip to content

Address issue #500 #502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
daveshanley merged 11 commits into from
Jan 23, 2026
Merged

Address issue #500 #502

daveshanley merged 11 commits into from
Jan 23, 2026

Conversation

@daveshanley
Copy link
Member

@daveshanley daveshanley commented Jan 7, 2026 •
edited
Loading

Numbers in names is more common than I want it to be. the second hit means I need to do something about it.

Also addresses issue #501

@codecov
Copy link

codecov bot commented Jan 7, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 89.06250% with 28 lines in your changes missing coverage. Please review.
✅ Project coverage is 99.50%. Comparing base (3d63579) to head (d1e8510).
⚠️ Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
datamodel/high/base/example.go 69.23% 2 Missing and 2 partials ⚠️
datamodel/high/v3/path_item.go 75.00% 2 Missing and 2 partials ⚠️
datamodel/high/v3/security_scheme.go 69.23% 2 Missing and 2 partials ⚠️
datamodel/high/v3/callback.go 83.33% 1 Missing and 1 partial ⚠️
datamodel/high/v3/header.go 87.50% 1 Missing and 1 partial ⚠️
datamodel/high/v3/link.go 84.61% 1 Missing and 1 partial ⚠️
datamodel/high/v3/parameter.go 87.50% 1 Missing and 1 partial ⚠️
datamodel/high/v3/request_body.go 86.66% 1 Missing and 1 partial ⚠️
datamodel/high/v3/response.go 87.50% 1 Missing and 1 partial ⚠️
datamodel/low/v3/paths.go 86.66% 2 Missing ⚠️
... and 1 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #502      +/-   ##
==========================================
- Coverage   99.60%   99.50%   -0.11%     
==========================================
  Files         189      189              
  Lines       22743    22872     +129     
==========================================
+ Hits        22654    22759     +105     
- Misses         56       68      +12     
- Partials       33       45      +12
Flag Coverage Δ
unittests 99.50% <89.06%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@daveshanley
Address issue #500
020dd64 
Numbers in names is more common than I want it to be. the second hit means I need to do something about it.
@daveshanley
Address #501
5563428 
Adds RenderExternalRef() helper functions in shared.go that:

- Check if a low-level object is an external reference
- Resolve it via `FindComponent()`
- Build new low/high level objects from the resolved YAML
- Render the resolved content instead of the empty values
@daveshanley
working on coverage
67237ef
@daveshanley
tune up hashing algorithm.
89ae6d4 
runs much cooler now, less allocations, less page faults, less memory. When run at scale, this thing was heating up like crazy.
@daveshanley
bumping coverage
3ac7f50
@daveshanley
Copy link
Member Author

daveshanley commented Jan 23, 2026

I cannot cover some of these lines, they require rigging that I can't create reasonably.

@daveshanley
Resolved #503
d1e8510 
components with ‘x-‘ prefix are now supported.
@daveshanley daveshanley merged commit c579fac into main Jan 23, 2026
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@daveshanley