fix: avoid unaligned 64-bit atomic panic on 32-bit platforms#289
Open
siretart wants to merge 1 commit into
Open
fix: avoid unaligned 64-bit atomic panic on 32-bit platforms#289siretart wants to merge 1 commit into
siretart wants to merge 1 commit into
Conversation
Reorder fields in regexCacheWatcher to place int64 counters before the *sync.Map pointer. On 32-bit architectures (i386, armhf), pointers are 4 bytes, causing the int64 fields to start at offset 4 -- which is not 8-byte aligned. Go's sync/atomic.AddInt64 panics when the target int64 is not 8-byte aligned on 32-bit platforms. Found during Debian package build (golang-github-pb33f-libopenapi-validator) on i386 and armhf.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #289 +/- ##
==========================================
- Coverage 98.08% 97.65% -0.43%
==========================================
Files 64 65 +1
Lines 6987 7133 +146
==========================================
+ Hits 6853 6966 +113
- Misses 133 134 +1
- Partials 1 33 +32
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reorder fields in regexCacheWatcher to place int64 counters before
the *sync.Map pointer. On 32-bit architectures (i386, armhf), pointers
are 4 bytes, causing the int64 fields to start at offset 4 -- which
is not 8-byte aligned. Go's sync/atomic.AddInt64 panics when the
target int64 is not 8-byte aligned on 32-bit platforms.
Found during Debian package build (golang-github-pb33f-libopenapi-validator)
on i386 and armhf.