Fix tests breaking with libopenapi v0.38.0 lazy getters#286
Open
siretart wants to merge 2 commits into
Open
Conversation
Signed-off-by: Reinhard Tartler <siretart@tauware.de>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #286 +/- ##
=======================================
Coverage 97.63% 97.63%
=======================================
Files 64 64
Lines 6991 6991
=======================================
Hits 6826 6826
Misses 132 132
Partials 33 33
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libopenapi v0.38.0 introduced lazy
GetSpecJSONgetters which broke validation tests that relied on manually corrupting the struct fields.\n\nSinceValidateOpenAPIDocumentfalls back to evaluating the lazy getters, those tests fail because the manual corruption gets overwritten by the lazy JSON parser. Pre-warming the lazy parser before mutating the fields ensures the fallback path triggers as expected.