Fix panic on missing or non-map query parameter object

[SebTardif]

Problem

In parameters/query_parameters.go, the helpers.Object case uses a bare type assertion:

encodedObj[params[p].Name].(map[string]interface{})

This panics when:

1. encodedObj is nil (e.g. content-wrapped parameter with a non-JSON media type skips map initialization)
2. The key params[p].Name is absent from encodedObj (map lookup returns nil, bare assertion on nil panics)
3. The value is present but is not a map[string]interface{}

Fix

Replace the bare type assertion with a three-step comma-ok pattern:

if encodedObj == nil {
    break skipValues
}
objVal, objExists := encodedObj[params[p].Name]
if !objExists || objVal == nil {
    break skipValues
}
objMap, mapOk := objVal.(map[string]interface{})
if !mapOk {
    break skipValues
}

This follows the existing control flow: when the value cannot be decoded, we break skipValues (the same pattern used for JSON unmarshal failures a few lines above).

Test

Added TestQueryParamObjectMissingKey_NoPanic which declares an object query parameter with a text/plain content wrapper. This forces the contentWrapped path without JSON decoding, leaving encodedObj nil. Before the fix, this test panics. After the fix, it completes without error.

[codecov]

Codecov Report

❌ Patch coverage is 77.77778% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.53%. Comparing base (54cf7b7) to head (069d2e1).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
parameters/query_parameters.go	46.66%	6 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #278      +/-   ##
==========================================
- Coverage   97.63%   97.53%   -0.11%     
==========================================
  Files          64       64              
  Lines        6991     7026      +35     
==========================================
+ Hits         6826     6853      +27     
- Misses        132      138       +6     
- Partials       33       35       +2     

Flag	Coverage Δ
unittests	97.53% <77.77%> (-0.11%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[daveshanley]

two lines missing coverage... you can do it :)

[SebTardif]

@daveshanley

two lines missing coverage... you can do it :)

Fixed in d002a64. The guards now emit a QueryParameterCannotBeDecoded validation error (modeled after HeaderParameterCannotBeDecoded) instead of silently breaking. Updated the test to assert on the returned error and added a positive test for valid JSON object parameters.

[daveshanley]

Coverage is a big drop-off; need to bring it up! The libs are something I am anal about coverage on.

[SebTardif]

@daveshanley Coverage improved in 069d2e1:

• errors/parameter_errors.go: QueryParameterCannotBeDecoded now has a direct unit test in the errors/ package (0% to 100% per-package coverage, 98.0% to 98.9% overall).
• parameters/query_parameters_test.go: Added 5 integration tests covering JSON content-wrapped (valid + invalid schema), form-encoded (valid + invalid), and XML content type paths through the object parameter validation.

The remaining uncovered lines are the bodies of guards 2 and 3 (!objExists || objVal == nil and !mapOk). These are defensive checks: all current encoding helpers (ConstructParamMapFromFormEncodingArrayWithSchema, ConstructParamMapFromDeepObjectEncoding, etc.) always produce a map[string]interface{} value for the parameter key, so the guard bodies are unreachable through the public API. They protect against future changes to the helper functions.