fix: update test snapshots for yaml.v4 word-wrapping behavior - #6
Open
siretart wants to merge 1 commit into
Open
fix: update test snapshots for yaml.v4 word-wrapping behavior#6siretart wants to merge 1 commit into
siretart wants to merge 1 commit into
Conversation
Newer versions of go.yaml.in/yaml/v4 introduce changes to how yaml.Node structures are serialized to text. Specifically, long string fields (like description fields in OpenAPI specs) are now automatically word-wrapped at 80 columns. The tests in pkg/overlay assert equality by comparing serialized YAML nodes against hardcoded snapshot files (openapi-overlayed.yaml and overlay-generated.yaml). Because the previous snapshots contained unwrapped long lines, these tests failed when building with the upgraded YAML parser. This commit updates the yaml.v4 dependency to v4.0.0-rc.5 and regenerates the test snapshots so they match the newly expected word-wrapped format, preventing CI failures in environments using newer dependencies. Signed-off-by: Reinhard Tartler <siretart@tauware.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: update test snapshots for yaml.v4 word-wrapping behavior
Newer versions of go.yaml.in/yaml/v4 introduce changes to how yaml.Node
structures are serialized to text. Specifically, long string fields
(like description fields in OpenAPI specs) are now automatically
word-wrapped at 80 columns.
The tests in pkg/overlay assert equality by comparing serialized YAML
nodes against hardcoded snapshot files (openapi-overlayed.yaml and
overlay-generated.yaml). Because the previous snapshots contained
unwrapped long lines, these tests failed when building with the
upgraded YAML parser.
This commit updates the yaml.v4 dependency to v4.0.0-rc.5 and
regenerates the test snapshots so they match the newly expected
word-wrapped format, preventing CI failures in environments using
newer dependencies.
Signed-off-by: Reinhard Tartler siretart@tauware.de