fix: isolate files in nested local operations#17399
Draft
rasitakyol wants to merge 1 commit into
Draft
Conversation
rasitakyol
force-pushed
the
agent/fix-local-api-file-isolation
branch
from
July 18, 2026 13:40
bf1ad49 to
2619a46
Compare
Contributor
Author
|
CI note: the current failing job is E2E - lexical__collections__LexicalViewsProviderDefault [next]. Its two failures time out waiting for This PR only changes the local create/update upload handling and Could a maintainer rerun the failed Actions job? I do not have permission to rerun workflows in the upstream repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
req.filefor child Local API create and update operations that reuse a caller request.Why?
Nested Local API operations currently write their file state onto the shared request. A file-less child operation can therefore clear the outer request's file before later hooks use it.
How?
isolateObjectPropertyutility so childfilewrites remain local while transaction, user, and context state stays shared.test/uploads/int.spec.tspassed 111/111 on SQLite and MongoDB,pnpm build:payload --force, Prettier, source ESLint, andgit diff --checkpassed.Fixes #15975