You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Keep polymorphic relationship columns when a Drizzle in query receives an empty array.
Why?
The type-pruning guards treated an empty array as matching every value-type check. For UUID-backed polymorphic relationships, this removed every query column, dropped the filter entirely, and returned all documents instead of none.
How?
Apply the existing numeric and UUID type-pruning rules only to non-empty arrays. A focused integration test creates a polymorphic relationship, queries it with in: [], verifies that no documents are returned, and cleans up its records.
CI note after rebasing onto current main to trigger the previously approval-blocked full workflow: build, lint, and 164 checks are passing.
LexicalAutosaveBlock, LexicalJSXConverter, and LexicalLinkFeature all failed during Payload initialization with the same transient MongoDB catalog-change error (payload._array-fields_versions, payloadInitError: true). The editor was then absent on every retry, before the suite logic could exercise this Drizzle query patch. The same initialization signature occurred concurrently across #17354, #17355, #17371, and #17372, whose diffs are unrelated. All Green is only the aggregate failure; the cancelled notify-next-canary jobs are ancillary concurrency cancellations.
No patch change is indicated by these logs. A maintainer rerun of the failed E2E jobs would be appreciated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Keep polymorphic relationship columns when a Drizzle
inquery receives an empty array.Why?
The type-pruning guards treated an empty array as matching every value-type check. For UUID-backed polymorphic relationships, this removed every query column, dropped the filter entirely, and returned all documents instead of none.
How?
Apply the existing numeric and UUID type-pruning rules only to non-empty arrays. A focused integration test creates a polymorphic relationship, queries it with
in: [], verifies that no documents are returned, and cleans up its records.Validation:
PAYLOAD_DATABASE=sqlite-uuid pnpm test:int relationships(58 passed, 4 skipped)PAYLOAD_DATABASE=postgres-uuid pnpm test:int relationships(58 passed, 4 skipped)pnpm build:drizzlegit diff --checkon the changed filesFixes #16195