fix(ui): use latest server response when resetting form after unpublish#16762
Open
raunak3208 wants to merge 2 commits into
Open
fix(ui): use latest server response when resetting form after unpublish#16762raunak3208 wants to merge 2 commits into
raunak3208 wants to merge 2 commits into
Conversation
raunak3208
requested review from
AlessioGr,
JarrodMFlesch and
jacobsfletch
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Updates the Unpublish button form reset flow to use the latest server response instead of stale
dataFromProps.Why?
When
beforeChangehooks modify field values during unpublish (e.g. settingpublishedAttonull), the database updates correctly but the admin UI continues showing stale values until a manual reload.This happened because the form was being reset using the initial page data instead of the updated response returned by the server.
How?
After a successful unpublish request, the response body is now parsed with
res.json()and passed toresetForm, ensuring the form reflects the latest persisted document state.Fixes #16754