feat(ui): add TableSection abstraction for list views#16756
Draft
JarrodMFlesch wants to merge 22 commits into
Draft
feat(ui): add TableSection abstraction for list views#16756JarrodMFlesch wants to merge 22 commits into
JarrodMFlesch wants to merge 22 commits into
Conversation
TableSection provides a consistent structure for list tables: - Root wrapper with automatic dividers between sections - Header with heading and action slots (48px height) - Content area with gutter padding - Footer for pagination controls ListControlsBar provides a simple container for search/filter controls.
- renderTable: wrap tables in TableSection with header/content/footer - List view: remove wrapper div, simplify structure - HierarchyList: use TableSection and ListControlsBar - GroupByHeader: simplify to just render ListSelection (heading moved to TableSectionHeader) - Remove redundant layout styles now handled by TableSection
Update test selectors from .group-by-header to .table-section__header and .group-by-header__heading to .table-section__heading
- NoListResults: add margin for proper alignment with tables - PageControls/Table: remove redundant margin/padding now in TableSection
Contributor
📦 esbuild Bundle Analysis for payloadThis analysis was generated by esbuild-bundle-analyzer. 🤖
Largest pathsThese visualization shows top 20 largest paths in the bundle.Meta file: packages/next/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_shared.json, Out file: esbuild/exports/shared.js
Meta file: packages/richtext-lexical/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_shared.json, Out file: esbuild/exports/shared_optimized/index.js
DetailsNext to the size is how much the size has increased or decreased compared with the base branch of this PR.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactors hierarchy tables and group-by tables to use a shared layout abstraction called
TableSection. Previously these two table types had inconsistent padding, headers, and dividers—hierarchy tables used custom margins while group-by tables had their own styling. Now both share the same compound component structure with consistent 48px headers, proper dividers between grouped sections, and unified action slot positioning for bulk selection and pagination.The pagination controls in both table types now use
SimplePagination, a minimal prev/next component that fits within the table header. This replaces the larger pagination component that was awkward in grouped contexts.Also adds
GroupByControl, a dropdown for selecting the group-by field that adapts to the current theme. The theme prop propagates from Popup through PopupList to RadioGroup items, allowing the control to render correctly in both light and dark mode contexts.Minor fixes include preventing scroll jumps when list query params update and handling undefined fields in WhereBuilder conditions.