fix(translations): fall back to base language tag for Accept-Language matching #15076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matching \### Why? Some browsers send only regional tags like `ja-JP` in the `Accept-Language` header. When no exact match exists, the current behavior can fail to detect a supported base language, leading to missed localization. \### What? Allow language detection to fall back from a regional tag (e.g., `ja-JP`) to its base tag (`ja`) when the exact match is not supported. \### How? While parsing `Accept-Language`, check for an exact match in `acceptedLanguages`, and if none is found, split on `-` and try the base language tag before giving up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Some browsers send only regional tags like
ja-JPin theAccept-Languageheader. When no exact match exists, the current behavior can fail to detect a supported base language, leading to missed localization.What?
Allow language detection to fall back from a regional tag (e.g.,
ja-JP) to its base tag (ja) when the exact match is not supported.How?
While parsing
Accept-Language, check for an exact match inacceptedLanguages, and if none is found, split on-and try the base language tag before giving up.