Skip to content

Prepare dart package for publishing to pub.dev#1541

Merged
spacebear21 merged 3 commits into
payjoin:masterfrom
spacebear21:publish-dart-0-1-1
May 11, 2026
Merged

Prepare dart package for publishing to pub.dev#1541
spacebear21 merged 3 commits into
payjoin:masterfrom
spacebear21:publish-dart-0-1-1

Conversation

@spacebear21
Copy link
Copy Markdown
Collaborator

@spacebear21 spacebear21 commented May 8, 2026

This updates the dart/ folder structure to enable publishing working bindings to pub.dev

  • Add Dart-local Cargo patch config for monorepo development.
    • Patches payjoin-ffi, payjoin, payjoin-test-utils, and payjoin-mailroom to local workspace paths.
  • Gate Dart native build _test-utils on the presence of payjoin-ffi/dart/.cargo/config.toml.
    • Local monorepo checkouts include this file, so tests can use test services and shared vectors.
    • The file is excluded from the pub package, so published builds do not enable _test-utils.
  • Exclude local-only files from the pub package with .pubignore
  • Add package metadata to make dart pub publish --dry-run happy (license, changelog files, homepage and repo links)
  • Pin git dependencies by commit rev.
    • payjoin-ffi’s payjoin dependency points at the required rust-payjoin commit.
    • The Dart native wrapper points at the above commit
    • (using commit revs means we can publish immediately to pub.dev without going through a whole rust-payjoin 0.26 release now)
  • Add the root Cargo patch for the git payjoin dependency so workspace builds continue using the local payjoin crate.

Remaining steps to publish

   cd payjoin-ffi/dart
   dart pub publish
   git tag payjoin-dart-v0.1.1
   git push origin payjoin-dart-v0.1.1
Pull Request Checklist

Please confirm the following before requesting review:

@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented May 8, 2026

Coverage Report for CI Build 25690074999

Coverage remained the same at 85.294%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 13668
Covered Lines: 11658
Line Coverage: 85.29%
Coverage Strength: 395.83 hits per line

💛 - Coveralls

@spacebear21 spacebear21 force-pushed the publish-dart-0-1-1 branch from c0629be to 39db689 Compare May 8, 2026 19:15
0.14.8 was released today and has MSRV 1.88.
@spacebear21 spacebear21 force-pushed the publish-dart-0-1-1 branch 2 times, most recently from 828c48f to f47ad69 Compare May 11, 2026 18:09
Needs a bump from 0.25 since there were breaking API changes since
(NoopPersister was removed).
@spacebear21 spacebear21 force-pushed the publish-dart-0-1-1 branch from f47ad69 to 5711ee7 Compare May 11, 2026 18:31
@spacebear21 spacebear21 marked this pull request as ready for review May 11, 2026 18:31
@spacebear21
Copy link
Copy Markdown
Collaborator Author

Published v0.1.1 https://pub.dev/packages/payjoin from this branch and confirmed it works in the BBM branch SatoshiPortal/bullbitcoin-mobile#2041

Copy link
Copy Markdown
Collaborator

@benalleng benalleng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spacebear21 spacebear21 merged commit df719ff into payjoin:master May 11, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants