FEAT: Server-side pagination and sorting for Jobs page#109
Open
Divyansh Maheshwari (divyansh1010x) wants to merge 2 commits into
Open
FEAT: Server-side pagination and sorting for Jobs page#109Divyansh Maheshwari (divyansh1010x) wants to merge 2 commits into
Divyansh Maheshwari (divyansh1010x) wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jobs pagination + sorting
Adds server-side pagination and sorting to the Jobs page (UI +
/jobsAPI).Why this touches the API: the requirement was UI-only, but supporting sorting on arbitrary columns required extending
/jobs— a single-column cursor can't support multiple sort orders.Backend
order_by(whitelisted:id,created_at,updated_at) anddirection(asc/desc) query parameters.order_byvalues fall back tosystem_job_id.system_job_idis used as the tiebreaker for stable ordering.Frontend
20+,40+, etc. while more pages exist.Testing
Tested locally against the docker-compose stack:
Setup
Seed 25 jobs to create multiple pages (20/page):
1. First page returns a cursor
Expected:
count = 20has_more = truenext_cursorpresent (opaque base64)2. Cursor paging — no overlap across pages, including tied sort values
Jobs created in a tight loop share the same
created_at, which is where naive cursor pagination often fails. Verified that thesystem_job_idtiebreaker correctly handles this case.Expected:
created_atcontinue correctly across pages.3. UI (browser)
Verified:
20+,40+, etc. while more pages exist.