feat: Add header sanitization to XLSX converter task#51
Open
Divyanshu Tiwari (divyanshu-tiwari) wants to merge 3 commits intomainfrom
Open
feat: Add header sanitization to XLSX converter task#51Divyanshu Tiwari (divyanshu-tiwari) wants to merge 3 commits intomainfrom
Divyanshu Tiwari (divyanshu-tiwari) wants to merge 3 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an opt-in sanitize_headers feature to the XLSX-to-CSV converter so the first unskipped row can be normalized into machine-friendly column names for downstream processing.
Changes:
- Added
sanitize_headersconfiguration option to the XLSX converter. - Implemented header-row sanitization during XLSX sheet reading.
- Updated converter task README with the new option and an example configuration.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
internal/pkg/pipeline/task/converter/xlsx.go |
Adds sanitize_headers config plumbing and applies sanitization to the first unskipped row. |
internal/pkg/pipeline/task/converter/README.md |
Documents the new XLSX option and provides a YAML usage example. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Types of changes
This pull request adds support for sanitizing header row values when converting Excel files to CSV, making it easier to work with standardized column names in downstream processing. It introduces a new
sanitize_headersoption, updates the documentation, and implements the feature in the codebase.Feature: Header Sanitization for Excel-to-CSV Conversion
sanitize_headersboolean option to thexlsxconverter configuration. When enabled, the first unskipped row (assumed to be the header) will have its values normalized to lowercase with non-alphanumeric characters replaced by underscores. This helps create consistent and machine-friendly column names. [1] [2]Documentation Updates
README.mdfor the converter to document the newsanitize_headersoption, including a description and a YAML configuration example. [1] [2]Code Changes
readSheetfunction inxlsx.goto accept and handle thesanitizeHeadersparameter, applying the normalization logic to the header row when the option is enabled. [1] [2] [3]stringspackage to support the header normalization logic.Checklist