Skip to content

chore: remove element-internals-polyfill#3128

Merged
bennypowers merged 1 commit intomainfrom
chore/remove-element-internals-polyfill
May 5, 2026
Merged

chore: remove element-internals-polyfill#3128
bennypowers merged 1 commit intomainfrom
chore/remove-element-internals-polyfill

Conversation

@bennypowers
Copy link
Copy Markdown
Member

What I did

  1. remove element-internal-polyfill and all non-changelog references thereto

@bennypowers bennypowers requested a review from zeroedin May 5, 2026 02:40
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 5, 2026

⚠️ No Changeset found

Latest commit: 3ff0345

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link
Copy Markdown

netlify Bot commented May 5, 2026

Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit 513433f
😎 Deploy Preview https://deploy-preview-3128--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2026

✅ Commitlint tests passed!

More Info
{
  "valid": true,
  "errors": [],
  "warnings": [],
  "input": "chore: remove element-internals-polyfill"
}

@bennypowers
Copy link
Copy Markdown
Member Author

/agentic_review

@github-actions github-actions Bot added the AT passed Automated testing has passed label May 5, 2026
@github-actions

This comment has been minimized.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the element-internals-polyfill dependency and eliminates runtime/documentation references to it across the dev tooling, docs site, and component demos.

Changes:

  • Dropped element-internals-polyfill from tooling dependencies and the lockfile.
  • Removed polyfill imports from the dev server template, docs entrypoints, and multiple component demo pages.
  • Removed Safari/polyfill guidance from affected component READMEs and removed docs-site asset/import-map wiring for the polyfill.

Reviewed changes

Copilot reviewed 35 out of 36 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tools/pfe-tools/package.json Removes element-internals-polyfill from peer dependencies.
tools/pfe-tools/dev-server/plugins/templates/index.html Stops importing the polyfill in the dev-server HTML template.
package-lock.json Removes the polyfill package entry and associated dependency references.
elements/pf-v5-tabs/README.md Removes Safari/polyfill note from tabs documentation.
elements/pf-v5-switch/README.md Removes Safari/polyfill note from switch documentation.
elements/pf-v5-switch/demo/without-label.html Removes polyfill import from demo.
elements/pf-v5-switch/demo/reversed.html Removes polyfill import from demo.
elements/pf-v5-switch/demo/nested-in-label.html Removes polyfill import from demo.
elements/pf-v5-switch/demo/index.html Removes polyfill import from demo.
elements/pf-v5-switch/demo/disabled.html Removes polyfill import from demo.
elements/pf-v5-switch/demo/checked.html Removes polyfill import from demo.
elements/pf-v5-progress-stepper/demo/step-descriptions.html Removes polyfill import from demo.
elements/pf-v5-progress-stepper/demo/info.html Removes polyfill import from demo.
elements/pf-v5-progress-stepper/demo/index.html Removes polyfill import from demo.
elements/pf-v5-progress-stepper/demo/danger.html Removes polyfill import from demo.
elements/pf-v5-progress-stepper/demo/custom-icons.html Removes polyfill import from demo.
elements/pf-v5-progress-stepper/demo/compact.html Removes polyfill import from demo.
elements/pf-v5-progress-stepper/demo/alignment.html Removes polyfill import from demo.
elements/pf-v5-jump-links/demo/vertical.html Removes polyfill import from demo.
elements/pf-v5-jump-links/demo/vertical-with-label.html Removes polyfill import from demo.
elements/pf-v5-jump-links/demo/scrollspy-with-subsections.html Removes polyfill import from demo.
elements/pf-v5-jump-links/demo/label.html Removes polyfill import from demo.
elements/pf-v5-jump-links/demo/index.html Removes polyfill import from demo.
elements/pf-v5-jump-links/demo/expandable-vertical-with-subsection.html Removes polyfill import from demo.
elements/pf-v5-jump-links/demo/centered-list.html Removes polyfill import from demo.
elements/pf-v5-button/demo/variants.html Removes polyfill import from demo.
elements/pf-v5-button/demo/stateful.html Removes polyfill import from demo.
elements/pf-v5-button/demo/sizes.html Removes polyfill import from demo.
elements/pf-v5-button/demo/index.html Removes polyfill import from demo.
elements/pf-v5-button/demo/form-control.html Removes polyfill import from demo.
elements/pf-v5-button/demo/block.html Removes polyfill import from demo.
docs/main.mjs Removes polyfill import from docs entry module.
docs/components/demos.html Removes inline module import of the polyfill.
docs/_plugins/pfe-assets.cjs Stops copying the polyfill assets into the docs site.
docs/_data/importMap.cjs Removes polyfill from generated import map dependencies.
core/pfe-core/controllers/internals-controller.ts Removes polyfill-related comment block around the disabled pseudo workaround.
Comments suppressed due to low confidence (1)

core/pfe-core/controllers/internals-controller.ts:279

  • The #polyfillDisabledPseudo() cleanup left an orphaned // END polyfill-disabled marker (the corresponding START marker/comments were removed). This looks like a partial removal and makes the method harder to read/search; either remove the END marker as well or restore a matching START marker if it's used for tooling.
  #polyfillDisabledPseudo() {
    const orig = (this.element as FACE).formDisabledCallback;
    (this.element as FACE).formDisabledCallback = disabled => {
      this._formDisabled = disabled;
      orig?.call(this.host, disabled);
    // END polyfill-disabled
    };
  }

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@bennypowers bennypowers enabled auto-merge (squash) May 5, 2026 02:51
@bennypowers bennypowers merged commit 402b3b0 into main May 5, 2026
27 checks passed
@bennypowers bennypowers deleted the chore/remove-element-internals-polyfill branch May 5, 2026 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AT passed Automated testing has passed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants