Fix toolbox block resolution and surface installed versions#282
Merged
milanofthe merged 1 commit intomainfrom May 5, 2026
Merged
Fix toolbox block resolution and surface installed versions#282milanofthe merged 1 commit intomainfrom
milanofthe merged 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
loadFromUrlParamnow runs at the end of the bootstrap chain (autoDetectBackend → initBackendFromUrl → initPyodide → bootstrapToolboxes → loadFromUrlParam). Previously these ran in parallel, so URL-loaded models could mount their nodes beforenodeRegistryhad the toolbox blocks registered, leaving them stuck rendering as missing.typeDef:BaseNodesubscribes toregistryVersionand re-derivestypeDefwhenever a toolbox is installed/uninstalled. Missing blocks now heal automatically when their toolbox arrives, and revert to missing again on uninstall.buildBlockDefinitionwas throwing awayconfig.importPath, so generated Python always hitfrom pathsim.blocks import Xeven for toolbox classes. NowNodeTypeDefinitioncarries an optionalimportPath, toolbox-registered blocks set it to their config'simportPath, and codegen prefers it:typeDef.importPath ?? blockImportPaths[blockClass] ?? 'pathsim.blocks'.loadGraphFilecallsresetSimulation()which wipes Python globals, butinstaller.tscachedhelpersLoaded = truein JS, so the next install hitNameError: '_pv_already_installed'. Cache removed; the sentinel check runs on everyensureHelpers(single cheapevaluate).