feat(passkey): passkey provider, passkey login and WebAuthn MFA (server)#616
Open
brkfun wants to merge 1 commit into
Open
feat(passkey): passkey provider, passkey login and WebAuthn MFA (server)#616brkfun wants to merge 1 commit into
brkfun wants to merge 1 commit into
Conversation
Server-side implementation of three coordinated passkey features (see the passbolt_styleguide and passbolt_browser_extension counterparts). Passkey / WebAuthn support is a long-standing community request. - Passkey login (passwordless): a new PasskeyAuthentication plugin — login and setup begin/finish (unauthenticated login is anti-enumeration; setup stores the credential + the server half of the passphrase kit), credential management (list / delete by credential id), and a CE organization toggle (admin-only write, unauthenticated-readable). Non-resident credentials so several passkeys can be enrolled per authenticator. - Passkey MFA: WebAuthn/FIDO2 as a new MultiFactorAuthentication provider (setup/verify begin/finish, credentials table + email notifications), mirroring Yubikey/TOTP/Duo. - Passkey provider: a v5-passkey resource type + a passkeys array in the v5 secret definitions, so provider passkeys are stored as encrypted vault secrets. Includes 39 PHPUnit tests (green against a test DB); passes composer cs-check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is a (multiple allowed):
Checklist
What you did
Server-side implementation of the three passkey features above.
New
PasskeyAuthenticationplugin (CE):/passkey/login/begin+/passkey/login/finish(unauthenticated,anti-enumeration — always 200),
/passkey/setup/begin+/passkey/setup/finish(authenrolment storing the credential + the server half of the passphrase kit),
/passkey/collect.GET /passkey/settings(list credentials),DELETE /passkey/settings/{id}(delete one by base64url credential id, or all).
GET/POST /passkey/organization/settingsto enable/disablepasskey login org-wide (admin-only write, unauthenticated-readable).
RESIDENT_KEY_DISCOURAGED) so several passkeys can be enrolled perauthenticator; login supplies the user id + allowCredentials.
MultiFactorAuthentication plugin: WebAuthn/FIDO2 as a new MFA provider (setup/verify
credentials table + email notifications), mirroring the Yubikey / TOTP / Duo structure.
Passkey provider storage: a
v5-passkey-aware resource type + apasskeysarray in the v5 secretdefinitions, so provider passkeys are stored as encrypted vault secrets.
User stories
the server returns assertion options scoped to that user without revealing whether the
persisted; given a non-admin, when they POST, then they get 403.
Fix included
PasskeyOrganizationSettingsService::setEnabled()persisted a raw array where the organization settingstable validates a UTF8 string, so the admin toggle 500'd on every save — now JSON-encode
read side and every other org setting.
Tests
39 new PHPUnit tests (controllers, services, organization settings) executed green locally against a
test DB; existing passkey tests still pass.
composer cs-checkclean.