🎨 Palette: Improve accessibility of New Agent form - #80
Conversation
Add ARIA roles (`radiogroup`, `radio`) and `aria-checked` states to the custom vendor selection buttons. Associate all form labels with their corresponding inputs (Repo, Model, Task) using `htmlFor` and `id` attributes. Add an `aria-label` to the branch input which lacks a visible label. Add a new learning to the Palette journal regarding these accessibility requirements. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 995b0fa42d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| role="radio" | ||
| aria-checked={selected} | ||
| onClick={() => setVendor(v)} |
There was a problem hiding this comment.
For keyboard-only users, these elements now expose themselves as a radio group, but they retain ordinary button behavior: every option remains in the Tab sequence, and Arrow keys do not move selection within the group. Add roving tabIndex and Arrow-key handling, or use native radio inputs, so the interaction matches the announced radio semantics.
Useful? React with 👍 / 👎.
1 participant
💡 What: Added essential accessibility attributes to the New Agent Modal form.
🎯 Why: The custom vendor selection UI was built using un-semantic
divandbuttonelements acting as a radio group, which screen readers couldn't properly interpret. Furthermore, several form inputs lacked explicit association with their text labels, making navigation difficult for assistive technologies.📸 Before/After: Screen readers will now announce the vendor selection as a radio group with checked/unchecked states, and all inputs will have correctly announced labels when focused.
♿ Accessibility:
role="radiogroup"to the vendor container.role="radio"andaria-checkedto the vendor buttons.idandhtmlForpairings for Repo, Model, and Task inputs.aria-labelto the branch input.PR created automatically by Jules for task 12531572640638336225 started by @parvezk