π‘οΈ Sentinel: [CRITICAL] Fix missing authentication on sources endpoint - #78
π‘οΈ Sentinel: [CRITICAL] Fix missing authentication on sources endpoint#78parvezk wants to merge 1 commit into
Conversation
Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
π¨ Severity: CRITICAL
π‘ Vulnerability: The endpoint
/api/jules/sources/route.tswas missing an authentication check. This endpoint makes an external API call using a server-side API key, completely bypassing Supabase Row Level Security (RLS). This allowed any unauthenticated user to trigger external API calls and view connected sources using the server's key.π― Impact: Unauthenticated users could enumerate connected Jules sources and abuse the server-side API key limits by making unauthorized requests.
π§ Fix: Added
currentUserId()check to the top of the route handler, returning a 401 Unauthorized error if no user ID is present.β Verification: Verified the route successfully fails securely when
currentUserId()returns null by verifying the tests and building the app.PR created automatically by Jules for task 10927758247135642653 started by @parvezk