Skip to content

🛡️ Sentinel: [MEDIUM] Fix local info disclosure and stack trace leaks - #71

Open
parvezk wants to merge 1 commit into
mainfrom
sentinel-secure-state-and-error-11128578396142026876
Open

🛡️ Sentinel: [MEDIUM] Fix local info disclosure and stack trace leaks#71
parvezk wants to merge 1 commit into
mainfrom
sentinel-secure-state-and-error-11128578396142026876

Conversation

@parvezk

@parvezk parvezk commented Jul 27, 2026

Copy link
Copy Markdown
Owner

🚨 Severity: MEDIUM

💡 Vulnerability:

  1. Local Information Disclosure: The CLI tool stores session data (which might contain sensitive information like authentication metadata or tool execution outputs) in a local ~/.polyagent/state.json file. It was created using default permissions, meaning depending on the OS's umask, it could be globally readable by other users on the system.
  2. Information Leakage via Errors: The main CLI script used program.parseAsync() but lacked a .catch() block. Unhandled exceptions (such as API keys missing, or internal runtime errors) would dump a full Node.js stack trace, exposing internal repository paths and potentially other context to the terminal.

🎯 Impact:

  • Local users on a shared machine could potentially read sensitive CLI state data.
  • Attackers or users encountering an error would see verbose stack traces instead of a secure, handled error message.

🔧 Fix:

  • Updated src/state.ts to enforce 0o700 permissions on the ~/.polyagent directory and 0o600 on the state.json file.
  • Appended a .catch() block to src/cli.ts's parseAsync() call that prints a clean, controlled error message and exits with a 1 code, without the stack trace.

Verification:

  • Ran npm test successfully (0 failures).
  • Executed npx tsx src/cli.ts dispatch "test" --vendor claude without an API key to verify that the CLI prints a clean Error: message without dumping the stack trace.

PR created automatically by Jules for task 11128578396142026876 started by @parvezk

- Added `.catch()` block to CLI entry point (`src/cli.ts`) to prevent unhandled rejection stack traces from leaking internal details to the console.
- Updated `StateStore` (`src/state.ts`) to use secure file permissions (`0o600` for files, `0o700` for directories) when saving session state, preventing local information disclosure.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@vercel

vercel Bot commented Jul 27, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
polyagent Ready Ready Preview, Comment Jul 27, 2026 9:01am

@cursor

cursor Bot commented Jul 27, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 69370d4224

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/state.ts
mkdirSync(dirname(this.path), { recursive: true, mode: 0o700 });
const data: StateFile = { sessions: this.sessions };
writeFileSync(this.path, JSON.stringify(data, null, 2));
writeFileSync(this.path, JSON.stringify(data, null, 2), { mode: 0o600 });

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Tighten permissions on pre-existing state files

When upgrading an installation that already has a permissive state.json—the population exposed by the vulnerability being fixed—writeFileSync opens the existing inode and ignores the supplied creation mode, so a 0644 or 0666 file remains readable after every save; similarly, mkdirSync(..., { recursive: true }) does not tighten an existing directory. Explicitly change existing permissions with chmod/fchmod, or securely replace the file, so the fix protects existing users rather than only newly created stores.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant