🛡️ Sentinel: [MEDIUM] Fix local info disclosure and stack trace leaks - #71
🛡️ Sentinel: [MEDIUM] Fix local info disclosure and stack trace leaks#71parvezk wants to merge 1 commit into
Conversation
- Added `.catch()` block to CLI entry point (`src/cli.ts`) to prevent unhandled rejection stack traces from leaking internal details to the console. - Updated `StateStore` (`src/state.ts`) to use secure file permissions (`0o600` for files, `0o700` for directories) when saving session state, preventing local information disclosure. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 69370d4224
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| mkdirSync(dirname(this.path), { recursive: true, mode: 0o700 }); | ||
| const data: StateFile = { sessions: this.sessions }; | ||
| writeFileSync(this.path, JSON.stringify(data, null, 2)); | ||
| writeFileSync(this.path, JSON.stringify(data, null, 2), { mode: 0o600 }); |
There was a problem hiding this comment.
Tighten permissions on pre-existing state files
When upgrading an installation that already has a permissive state.json—the population exposed by the vulnerability being fixed—writeFileSync opens the existing inode and ignores the supplied creation mode, so a 0644 or 0666 file remains readable after every save; similarly, mkdirSync(..., { recursive: true }) does not tighten an existing directory. Explicitly change existing permissions with chmod/fchmod, or securely replace the file, so the fix protects existing users rather than only newly created stores.
Useful? React with 👍 / 👎.
🚨 Severity: MEDIUM
💡 Vulnerability:
~/.polyagent/state.jsonfile. It was created using default permissions, meaning depending on the OS'sumask, it could be globally readable by other users on the system.program.parseAsync()but lacked a.catch()block. Unhandled exceptions (such as API keys missing, or internal runtime errors) would dump a full Node.js stack trace, exposing internal repository paths and potentially other context to the terminal.🎯 Impact:
🔧 Fix:
src/state.tsto enforce0o700permissions on the~/.polyagentdirectory and0o600on thestate.jsonfile..catch()block tosrc/cli.ts'sparseAsync()call that prints a clean, controlled error message and exits with a1code, without the stack trace.✅ Verification:
npm testsuccessfully (0 failures).npx tsx src/cli.ts dispatch "test" --vendor claudewithout an API key to verify that the CLI prints a cleanError:message without dumping the stack trace.PR created automatically by Jules for task 11128578396142026876 started by @parvezk