⚡ Bolt: Optimize session drawer polling and re-renders - #70
Conversation
Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 85527e8884
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // Optimization: Disable polling when the session is in a terminal state (completed or failed). | ||
| // Impact: Saves 1 network request and database read every 4 seconds for completed sessions. | ||
| const { data } = useSWR<DetailResponse>(session ? `/api/sessions/${session.id}` : null, fetcher, { | ||
| refreshInterval: session?.status === "completed" || session?.status === "failed" ? 0 : 4000, |
There was a problem hiding this comment.
When the drawer is opened while a session is running, session remains the snapshot stored by DashboardPage; subsequent /api/sessions refreshes update SessionTable but never update that selected object. Therefore, even after the detail response reports data.session.status as completed or failed, this expression continues returning 4000 and polls indefinitely. Derive the interval from the latest detail data, such as with SWR's functional refreshInterval, so sessions that finish while the drawer is open actually stop polling.
Useful? React with 👍 / 👎.
1 participant
💡 What
useEffectsynchronization pattern with a "derived state during render" pattern forsession.id.refreshIntervalpolling (setting to0) when a session reaches a terminal state (completedorfailed).🎯 Why
useEffectto synchronize internal component state with props causes an unnecessary double-render cycle, hurting frontend performance./api/sessions/[id]and wasted backend database reads.📊 Impact
🔬 Measurement
fetchrequests every 4 seconds.pnpm testand formatting viapnpm lint.PR created automatically by Jules for task 4884745908084273745 started by @parvezk