test: cover PostHog instrumentation initialization - #63
Draft
cursor[bot] wants to merge 1 commit into
Draft
Conversation
Co-authored-by: Parvez Kose <koseparvez@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Risky behavior now covered
A configuration regression in this entry point can silently stop analytics, send events to the wrong host, create unwanted person profiles, or duplicate pageview events. The tests isolate module imports and environment variables so each guard is deterministic.
Test files added
test/instrumentation-client.test.tsWhy this materially reduces regression risk
Existing coverage PRs test production-host gating and component pageview/identity calls, but not the SDK initialization boundary. These tests fail if initialization becomes unconditional, required configuration is ignored, or a behavior-sensitive PostHog option changes. A mutation of
capture_pageviewfromfalsetotruewas confirmed to fail the focused test.Validation
npm test— 39/39 passingnpm run buildnpx prettier --check test/instrumentation-client.test.ts