Skip to content

πŸ›‘οΈ Sentinel: [CRITICAL] Fix missing authentication on /api/jules/sources - #62

Open
parvezk wants to merge 1 commit into
mainfrom
fix-jules-sources-auth-3308054558918175974
Open

πŸ›‘οΈ Sentinel: [CRITICAL] Fix missing authentication on /api/jules/sources#62
parvezk wants to merge 1 commit into
mainfrom
fix-jules-sources-auth-3308054558918175974

Conversation

@parvezk

@parvezk parvezk commented Jul 25, 2026

Copy link
Copy Markdown
Owner

🚨 Severity: CRITICAL
πŸ’‘ Vulnerability: The /api/jules/sources endpoint lacked authentication checks, allowing unauthenticated users to trigger external API calls (realJulesPort(...).listSources()) using the server's API key. This happened because Next.js middleware in this project intentionally excludes /api paths from global authentication, requiring explicit checks for endpoints that bypass RLS (like those making external API calls).
🎯 Impact: Unauthorized access could lead to SSRF-like behavior, exhaustion of rate limits on the external API, or potential exposure of internal system configurations/data if the external call's response was leaked.
πŸ”§ Fix: Imported currentUserId from @/lib/sessions-store and added a check at the beginning of the GET route. If currentUserId() returns a falsy value (no user), the endpoint now returns a 401 Unauthorized status with a standard error message.
βœ… Verification: Verified that pnpm test in the root and pnpm lint and pnpm build in the web directory still pass. Also added a critical learning entry to .jules/sentinel.md documenting the vulnerability and how to prevent it in the future.


PR created automatically by Jules for task 3308054558918175974 started by @parvezk

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@vercel

vercel Bot commented Jul 25, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
polyagent Ready Ready Preview, Comment Jul 25, 2026 8:57am

@cursor

cursor Bot commented Jul 25, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant