RFC: Favourites API#16
Draft
filvecchiato wants to merge 7 commits into
Draft
Conversation
- Explain why Browse gets implicit privilege (default discovery product) - Rephrase motivation: hosts store data products can't access, bookmarks are one example; tie to DotNS being permissionless - Improve discovery UI bullet with concrete details - Lead Data Model section with the ProductRecord reference - Add NotSupported error variant for hosts without a favourites table - Remove empty Alternatives section
4 tasks
# Conflicts: # docs/rfcs/_index.md
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This reverts commit 97cdbd2.
Introduce the `Favourites` trait with subscribe, add, and forget methods for managing the host's bookmarked-product catalogue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the
Favouritestrait withsubscribe,add, andforgetmethods for managing the host's bookmarked-product catalogue. Products can query, add, and remove bookmarked apps from the host's local catalogue.Changes
rust/crates/truapi/src/api/favourites.rs— unifiedFavouritestrait with wire IDsrust/crates/truapi/src/v01/favourites.rs— v0.1 types (FavouriteProduct, request/response/error enums)rust/crates/truapi/src/versioned/favourites.rs— versioned wrappersdocs/rfcs/0013-favourites-api.md— RFC documentTest plan
cargo build --workspacecargo clippy --workspace --all-targets --all-features -- -D warningscargo test --workspace