Skip to content

fix(deploy): actionable error when cargo metadata fails (#396)#461

Open
illegalcall wants to merge 1 commit into
mainfrom
fix/396-cargo-metadata-actionable-error
Open

fix(deploy): actionable error when cargo metadata fails (#396)#461
illegalcall wants to merge 1 commit into
mainfrom
fix/396-cargo-metadata-actionable-error

Conversation

@illegalcall

Copy link
Copy Markdown
Contributor

What

cargo metadata failures during contract deploy dumped cdm-builder's raw Command failed: cargo metadata ... --no-deps. Remap it to an actionable message, mirroring the existing IPFS-migration remap.

Achieved

Clear guidance (Rust toolchain / network / bad Cargo.toml) plus cargo's own file and line, instead of a bare command echo.

Works

  • Verified end to end: a broken Cargo.toml deploy now shows the guidance + error: key with no value --> Cargo.toml:21:6.
  • Tests for the matcher, stderr preference, idempotency, and the deploy call site. Full suite green, typecheck/format/lint clean.

Doesn't

@github-actions

Copy link
Copy Markdown
Contributor

Dev build ready — try this branch:

curl -fsSL https://raw.githubusercontent.com/paritytech/playground-cli/main/install.sh | VERSION=dev/fix/396-cargo-metadata-actionable-error bash

@github-actions

github-actions Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

E2E Test Pass · ❌ FAIL

Tag: e2e-ci-pr · Branch: fix/396-cargo-metadata-actionable-error · Commit: 9b5f213 · Run logs

Cell Result Time
pr-preflight ❌ FAIL 2m38s
pr-deploy-foundry ✅ PASS 0m44s
pr-deploy-cdm ✅ PASS 3m32s
pr-login-session ❌ FAIL 5m09s
pr-mod ❌ FAIL 2m59s
pr-install ✅ PASS 0m49s
pr-deploy-frontend ❌ FAIL 3m02s
${{ matrix.cell }} ⏭️ SKIP 0m-1s
${{ matrix.cell }} ⏭️ SKIP 0m-1s
❌ Failed tests (1)
  • e2e/cli/session.test.ts › session management > corrupted session file does not produce a valid signer
    expected +0 not to be +0 // Object.is equality

Sentry traces: view spans for this run

Remap cdm-builder's raw "Command failed: cargo metadata ..." dump to a message that explains the likely causes and keeps cargo's own file/line, so a bad Cargo.toml stays fixable.
@illegalcall
illegalcall force-pushed the fix/396-cargo-metadata-actionable-error branch from 6e45105 to 2ce7c9b Compare July 21, 2026 05:49

@ReinhardHatko ReinhardHatko left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants