Skip to content

fix: remove deprecated curl_close() calls - #12

Open
mogliabr wants to merge 1 commit into
papi-ai:mainfrom
mogliabr:fix/remove-curl-close
Open

fix: remove deprecated curl_close() calls#12
mogliabr wants to merge 1 commit into
papi-ai:mainfrom
mogliabr:fix/remove-curl-close

Conversation

@mogliabr

Copy link
Copy Markdown

Problem

This package requires PHP ^8.2 (see composer.json), and curl_close()
is deprecated as of PHP 8.5. Running on 8.5 emits deprecation notices from
the curl_close() calls in the provider.

Why removing is safe

curl_close() has been a no-op since PHP 8.0: the CurlHandle is freed
automatically by the garbage collector once it goes out of scope. Because
the package already targets ^8.2, there is no PHP 7 path where an
explicit close is required, so the calls can be removed outright with no
change in behavior.

Change

Removes the curl_close() calls.

Compatibility note

Since this package targets ^8.2, removing the calls is the right change.
If a downstream fork ever needs to support PHP 7, keep the explicit close
behind a version check rather than removing it:

private function closeCurl($handle): void
{
    if (PHP_VERSION_ID < 80000) {
        curl_close($handle);
    }
}

curl_close() is a no-op since PHP 8.0 and deprecated as of PHP 8.5.
The package targets ^8.2, so the calls can be removed outright.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant