fix: remove deprecated curl_close() calls - #12
Open
mogliabr wants to merge 1 commit into
Open
Conversation
curl_close() is a no-op since PHP 8.0 and deprecated as of PHP 8.5. The package targets ^8.2, so the calls can be removed outright.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
This package requires PHP
^8.2(seecomposer.json), andcurl_close()is deprecated as of PHP 8.5. Running on 8.5 emits deprecation notices from
the
curl_close()calls in the provider.Why removing is safe
curl_close()has been a no-op since PHP 8.0: theCurlHandleis freedautomatically by the garbage collector once it goes out of scope. Because
the package already targets
^8.2, there is no PHP 7 path where anexplicit close is required, so the calls can be removed outright with no
change in behavior.
Change
Removes the
curl_close()calls.Compatibility note
Since this package targets
^8.2, removing the calls is the right change.If a downstream fork ever needs to support PHP 7, keep the explicit close
behind a version check rather than removing it: