Document and fix command sanitizing with shlex.split#3245
Open
kdeldycke wants to merge 1 commit intopallets:stablefrom
Open
Document and fix command sanitizing with shlex.split#3245kdeldycke wants to merge 1 commit intopallets:stablefrom
shlex.split#3245kdeldycke wants to merge 1 commit intopallets:stablefrom
Conversation
Removes last use of `shell=True` use for command invokation for defense-in-depth. Refs: pallets#1026, pallets#1477 and pallets#2775
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also removes last use of
shell=Trueuse for command invokation for defense-in-depth.Context
I was trying to eliminate the last usage of
shell=Trueinsubprocess.Popen, then had to resort to usingshlex.splitinedit_files. This led me into the rabbit hole ofshlex.splitusage in_termui_impl.pyfile. Which I use as an opportunity to document past choices from older issues and PRs.Tests
I also use that opportunity to collect test cases discussed in older related issues and PRs to illustrate and cover how we are expecting command path to be unquoted and interpreted on POSIX systems and Windows.
Related